Skip to content

Give ASAN builds a larger ReservedZone size to handle stack overflows.#21253

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
MenloDorian:eng/Give-ASAN-builds-a-larger-ReservedZone-size-to-handle-stack-overflows-
Dec 4, 2023
Merged

Give ASAN builds a larger ReservedZone size to handle stack overflows.#21253
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
MenloDorian:eng/Give-ASAN-builds-a-larger-ReservedZone-size-to-handle-stack-overflows-

Conversation

@MenloDorian
Copy link
Copy Markdown

@MenloDorian MenloDorian commented Dec 4, 2023

cefd987

Give ASAN builds a larger ReservedZone size to handle stack overflows.
https://bugs.webkit.org/show_bug.cgi?id=265779
rdar://119051471

Reviewed by Yusuke Suzuki.

This is because ASAN builds are memory hogs and need additional stack space.

* JSTests/stress/stack-overflow-in-syntax-checker.js: Added.
(try.262.agent.start.262.agent.receiveBroadcast):
(catch):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::overrideDefaults):

Canonical link: https://commits.webkit.org/271456@main

7f6a609

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@MenloDorian MenloDorian requested a review from a team as a code owner December 4, 2023 06:20
@MenloDorian MenloDorian self-assigned this Dec 4, 2023
@MenloDorian MenloDorian added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 4, 2023
Copy link
Copy Markdown
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=265779
rdar://119051471

Reviewed by Yusuke Suzuki.

This is because ASAN builds are memory hogs and need additional stack space.

* JSTests/stress/stack-overflow-in-syntax-checker.js: Added.
(try.262.agent.start.262.agent.receiveBroadcast):
(catch):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::overrideDefaults):

Canonical link: https://commits.webkit.org/271456@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Give-ASAN-builds-a-larger-ReservedZone-size-to-handle-stack-overflows- branch from 7f6a609 to cefd987 Compare December 4, 2023 07:28
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 271456@main (cefd987): https://commits.webkit.org/271456@main

Reviewed commits have been landed. Closing PR #21253 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cefd987 into WebKit:main Dec 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 4, 2023
@MenloDorian MenloDorian deleted the eng/Give-ASAN-builds-a-larger-ReservedZone-size-to-handle-stack-overflows- branch December 4, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants