[iOS] Adopt API replacements for returning an "acting parent UIScrollView"#21289
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 4, 2023
Merged
[iOS] Adopt API replacements for returning an "acting parent UIScrollView"#21289webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
whsieh
added
the
Platform
whsieh
requested review from
aprotyas,
hortont424,
megangardner,
pxlcoder and
rr-codes
Collaborator
|
EWS run on current version of this PR (hash 88aae6b) Details
|
pxlcoder
approved these changes
Dec 4, 2023
megangardner
approved these changes
Dec 4, 2023
webkit-commit-queue
force-pushed
the
eng/265801
branch
from
88aae6b to
d5472c3
Compare
…View" https://bugs.webkit.org/show_bug.cgi?id=265801 rdar://119141181 Reviewed by Aditya Keerthi and Megan Gardner. Adopt a soon-to-be API replacement for this SPI scroll view delegate method: ``` -[UIScrollViewDelegate _actingParentScrollViewForScrollView:] ``` The replacement is just a subclassing hook on `UIScrollView` directly, which we can easily route through our own `WKBaseScrollViewDelegate`, which allows us to share an implementation with the legacy `-_actingParentScrollViewForScrollView:` delegate method. * Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (-[WKScrollingNodeScrollViewDelegate _actingParentScrollViewForScrollView:]): (-[WKScrollingNodeScrollViewDelegate actingParentScrollViewForScrollView:]): * Source/WebKit/UIProcess/ios/WKBaseScrollView.h: * Source/WebKit/UIProcess/ios/WKBaseScrollView.mm: (-[WKBaseScrollView _actingParentScrollView]): Canonical link: https://commits.webkit.org/271512@main
webkit-commit-queue
force-pushed
the
eng/265801
branch
from
d5472c3 to
591cf10
Compare
Collaborator
|
Committed 271512@main (591cf10): https://commits.webkit.org/271512@main Reviewed commits have been landed. Closing PR #21289 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
591cf10
88aae6b
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 api-wpe🛠 gtk🧪 gtk-wk2🧪 api-gtk🛠 watch-sim