Failing to deserialize data from _WKWebExtensionSQLiteRow#21458
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 7, 2023
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 0c48a18) Details
|
b-weinstein
approved these changes
Dec 7, 2023
kiaraarose
added
the
unsafe-merge-queue
xeenon
approved these changes
Dec 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=266012 Reviewed by Brian Weinstein and Timothy Hatcher. We should be passing data.bytes as is. `- (NSData *)uncopiedDataAtIndex:(NSUInteger)index` needs a cast. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteRow.mm: (-[_WKWebExtensionSQLiteRow dataAtIndex:]): (-[_WKWebExtensionSQLiteRow uncopiedDataAtIndex:]): * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: Initialize with space for two items, not three. Canonical link: https://commits.webkit.org/271693@main
webkit-commit-queue
force-pushed
the
eng/Bug-fixes-extension-storage
branch
from
0c48a18 to
9e36fb6
Compare
Collaborator
|
Committed 271693@main (9e36fb6): https://commits.webkit.org/271693@main Reviewed commits have been landed. Closing PR #21458 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9e36fb6
0c48a18
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim