Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls. #21557

francescorn · 2023-12-09T03:00:09Z

`793932c`

Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls.
https://bugs.webkit.org/show_bug.cgi?id=258975

Reviewed by Devin Rousso.

If a CSS class has a !important tag on a property the slider does not work correctly.
This is due to us modifying the inline style, and the inline style is being overriden by
the css class !important property.

We can address this by checking if the !important property is being applied already
during _computeProperty(), and then if it is then append !important in the
writeFontVariation().

Rename resultProperties to resultProperty inside of _computeProperty() because there
is a single property being handled.

Delete _effectivePropertyValueForName function since it is not in use and create it in
_computeProperty instead to be used for resultProperty.isImportant.

* Source/WebInspectorUI/UserInterface/Models/FontStyles.js:
(WI.FontStyles.prototype.writeFontVariation):
(WI.FontStyles):

Canonical link: https://commits.webkit.org/275389@main

ff503c3

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-09T03:01:43Z

EWS run on previous version of this PR (hash b2d78f6)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-11T17:20:36Z

EWS run on previous version of this PR (hash 5292f06)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

rcaliman-apple · 2023-12-15T18:26:50Z

I see this is still a draft so I won't review it yet.

I also notice you closed the previous PR for the same task: #20015 That's unfortunate. There are useful comments in there. In general, it's preferable to keep the same PR and iterate on the code to maintain that history for people in the future who research why a patch was made a certain way.

rcaliman-apple · 2023-12-15T18:29:49Z

Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js

There's no need to modify the value here in the parsing stage when receiving it from the backend.
This is causing the inspector/css/modify-inline-style.html test to fail.

webkit-early-warning-system · 2023-12-15T21:07:37Z

EWS run on previous version of this PR (hash c3966d9)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	💥 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-21T17:49:53Z

EWS run on previous version of this PR (hash 3e6ed13)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-02-21T18:05:19Z

EWS run on previous version of this PR (hash a220164)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-21T21:37:22Z

EWS run on previous version of this PR (hash 31365b0)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	~~🛠 tv~~	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-02-21T23:57:24Z

EWS run on previous version of this PR (hash 13945c9)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	~~🛠 wincairo~~
	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-02-22T00:00:15Z

EWS run on previous version of this PR (hash 5a39e81)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

rcaliman-apple · 2024-02-22T22:21:58Z

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

This will change always add the !important suffix to the written property value.
It should be added only when the property value collected from the page originally was marked with !important.

To find identify that, you can update WI.FontStyles._computeProperty() to look at the important property of the WI.CSSProperty collected into WI.DOMNodeStyles.

Like this:

// returns true if the CSS property was authored with `!important` in its value (which exists on WI.CSSProperty._rawValue) style.domNodeStyle.effectivePropertyForName(name).important

Update the object returned by WI.FontStyles._computeProperty with an additional property, like isImportant or similar.

Note
The name of that return object is misleadingly pluralised now as resultProperties. It should be resultProperty since that method operates on a single property. Probably a typo from when it was written.

If you follow that return object, you'll notice it gets collected with the other ones for other CSS properties in WI.FontStyles._propertiesMap.

That's the map you can then check against in WI.FontStyles.writeFontVariation() to check whether the value of the CSS property you're trying to update was originally marked important. If so, concatenate the "!important" to targetPropertyValue.

You don't have to make any changes outside of WI.FontStyles to fix this bug. Please don't change WI.CSSProperty

rcaliman-apple · 2024-02-22T22:27:16Z

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

inspectorOverrideImportant does not exist on WI.CSSProperty. Please remove.

webkit-early-warning-system · 2024-02-23T00:35:46Z

EWS run on previous version of this PR (hash ce47351)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 gtk
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🧪 gtk-wk2
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

francescorn · 2024-02-23T00:38:25Z

themes.tiki.org works now, I appended !important whenever there is a CSS property with !important.

webkit-early-warning-system · 2024-02-23T00:42:17Z

EWS run on previous version of this PR (hash 923cd33)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 gtk
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🧪 gtk-wk2
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

rcaliman-apple

Thank you for fixing this.

rcaliman-apple · 2024-02-23T01:06:43Z

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

The code comment is redundant. Please remove it. I had put it in the code snippet in my review as an explanation for you

rcaliman-apple · 2024-02-23T01:09:56Z

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

Please rename resultProperties to resultProperty inside this method. The plural form is a typo from the original patch. This method deals with a single property.

webkit-early-warning-system · 2024-02-23T01:20:05Z

EWS run on previous version of this PR (hash 08170d6)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

dcrousso · 2024-02-23T01:44:01Z

Source/WebInspectorUI/UserInterface/Models/FontStyles.js

FYI we're already calling this inside _effectivePropertyValueForName, so i think we could/should avoid that

let effectivePropertyForName = style.domNodeStyle.effectivePropertyForName(name); let value = effectivePropertyForName?.value; ... resultProperty.isImportant = effectivePropertyForName?.important ?? false;

We need to keep return resultProperties included

Removing return resultProperties was causing web inspector test cases to fail, so I added it back

webkit-early-warning-system · 2024-02-23T05:45:25Z

EWS run on previous version of this PR (hash 4c81087)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-23T22:20:38Z

EWS run on previous version of this PR (hash a6e89fe)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	✅ 🛠 gtk
🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-24T01:41:13Z

EWS run on current version of this PR (hash ff503c3)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

rcaliman-apple · 2024-02-26T18:15:21Z

I'm ok with this landing. @dcrousso want to approve?

… don't get overridden when using the interactive editing controls. https://bugs.webkit.org/show_bug.cgi?id=258975 Reviewed by Devin Rousso. If a CSS class has a !important tag on a property the slider does not work correctly. This is due to us modifying the inline style, and the inline style is being overriden by the css class !important property. We can address this by checking if the !important property is being applied already during _computeProperty(), and then if it is then append !important in the writeFontVariation(). Rename resultProperties to resultProperty inside of _computeProperty() because there is a single property being handled. Delete _effectivePropertyValueForName function since it is not in use and create it in _computeProperty instead to be used for resultProperty.isImportant. * Source/WebInspectorUI/UserInterface/Models/FontStyles.js: (WI.FontStyles.prototype.writeFontVariation): (WI.FontStyles): Canonical link: https://commits.webkit.org/275389@main

webkit-commit-queue · 2024-02-27T17:38:27Z

Committed 275389@main (793932c): https://commits.webkit.org/275389@main

Reviewed commits have been landed. Closing PR #21557 and removing active labels.

francescorn requested review from dcrousso and patrickangle as code owners December 9, 2023 03:00

francescorn self-assigned this Dec 9, 2023

francescorn added the Web Inspector Bugs related to the WebKit Web Inspector. label Dec 9, 2023

francescorn requested a review from rcaliman-apple December 9, 2023 03:09

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 9, 2023

francescorn removed the merging-blocked Applied to prevent a change from being merged label Dec 11, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 11, 2023

francescorn marked this pull request as draft December 12, 2023 18:12

rcaliman-apple reviewed Dec 15, 2023

View reviewed changes

francescorn removed the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 16, 2023

francescorn marked this pull request as ready for review December 16, 2023 03:20

francescorn mentioned this pull request Dec 16, 2023

Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls. #20015

Closed

francescorn requested a review from rcaliman-apple December 16, 2023 03:33

francescorn marked this pull request as draft January 31, 2024 00:50

francescorn removed the merging-blocked Applied to prevent a change from being merged label Feb 21, 2024

rcaliman-apple requested changes Feb 22, 2024

View reviewed changes

francescorn marked this pull request as ready for review February 23, 2024 00:38

francescorn requested a review from rcaliman-apple February 23, 2024 00:39

rcaliman-apple reviewed Feb 23, 2024

View reviewed changes

francescorn requested a review from rcaliman-apple February 23, 2024 01:20

dcrousso reviewed Feb 23, 2024

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 23, 2024

francescorn removed the merging-blocked Applied to prevent a change from being merged label Feb 23, 2024

francescorn requested a review from dcrousso February 23, 2024 05:47

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 23, 2024

francescorn removed the merging-blocked Applied to prevent a change from being merged label Feb 23, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 24, 2024

francescorn removed the merging-blocked Applied to prevent a change from being merged label Feb 24, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 24, 2024

francescorn removed the merging-blocked Applied to prevent a change from being merged label Feb 24, 2024

dcrousso approved these changes Feb 27, 2024

View reviewed changes

stwrt added the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024

webkit-commit-queue merged commit 793932c into WebKit:main Feb 27, 2024

Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls. #21557

Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls. #21557

Uh oh!

Conversation

francescorn commented Dec 9, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rcaliman-apple commented Dec 15, 2023

Uh oh!

rcaliman-apple Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francescorn commented Feb 23, 2024

Uh oh!

webkit-early-warning-system commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rcaliman-apple left a comment

Choose a reason for hiding this comment

Uh oh!

rcaliman-apple Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francescorn Feb 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francescorn Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

francescorn commented Dec 9, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 11, 2023 •

edited

Loading

rcaliman-apple Dec 15, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2023 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 22, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 23, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 23, 2024 •

edited

Loading

rcaliman-apple Feb 23, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 23, 2024 •

edited

Loading

francescorn Feb 24, 2024 •

edited

Loading

francescorn Feb 26, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 23, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 23, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 24, 2024 •

edited

Loading