Skip to content

[WebGPU] Fix redundant move in return statement in expansion of macro WTFMove#21787

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
psaavedra:eng/WebGPU-Fix-redundant-move-in-return-statement-in-expansion-of-macro-WTFMove
Dec 14, 2023
Merged

[WebGPU] Fix redundant move in return statement in expansion of macro WTFMove#21787
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
psaavedra:eng/WebGPU-Fix-redundant-move-in-return-statement-in-expansion-of-macro-WTFMove

Conversation

@psaavedra
Copy link
Copy Markdown
Contributor

@psaavedra psaavedra commented Dec 14, 2023 •
edited by webkit-early-warning-system
Loading

512102a

[WebGPU] Fix redundant move in return statement in expansion of macro WTFMove
https://bugs.webkit.org/show_bug.cgi?id=266398

Reviewed by Mike Wyrzykowski.

This change fix a trivial build error in WPEWebKit and WebKitGTK when
ENABLE_GPU_PROCESS=ON.

* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp:
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass):

Canonical link: https://commits.webkit.org/272045@main

23582c9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@psaavedra psaavedra self-assigned this Dec 14, 2023
@psaavedra psaavedra added the WebGPU For bugs in WebGPU label Dec 14, 2023
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 14, 2023 •
edited
Loading

EWS run on current version of this PR (hash 23582c9)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 14, 2023
@psaavedra psaavedra added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Dec 14, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 14, 2023
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

webkit-ews-buildbot commented Dec 14, 2023

Safe-Merge-Queue: Build #6208.

@psaavedra
[WebGPU] Fix redundant move in return statement in expansion of macro…
512102a 
… WTFMove

https://bugs.webkit.org/show_bug.cgi?id=266398

Reviewed by Mike Wyrzykowski.

This change fix a trivial build error in WPEWebKit and WebKitGTK when
ENABLE_GPU_PROCESS=ON.

* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp:
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass):

Canonical link: https://commits.webkit.org/272045@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Fix-redundant-move-in-return-statement-in-expansion-of-macro-WTFMove branch from 23582c9 to 512102a Compare December 14, 2023 17:29
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Dec 14, 2023

Committed 272045@main (512102a): https://commits.webkit.org/272045@main

Reviewed commits have been landed. Closing PR #21787 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 512102a into WebKit:main Dec 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo tadeuzagallo is a code owner

Assignees

@psaavedra psaavedra

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@psaavedra @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @mwyrzykowski