[makeprop.pl] Make sure that CSSPropertyNames.gperf is generated in a deterministic manner
#2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
force-pushed
the
eng/The-CSSPropertyNames-cpp-file-is-code-generated-with-non-deterministic-contents
branch
from
7fa106f to
2ae69d2
Compare
fujii
approved these changes
Jul 8, 2022
… a deterministic manner https://bugs.webkit.org/show_bug.cgi?id=242457 <rdar://96607159> Reviewed by Fujii Hironori. Previously the switch-case statements for the properties were written out in a non-deterministic order. * Source/WebCore/css/makeprop.pl: Canonical link: https://commits.webkit.org/252297@main
webkit-early-warning-system
force-pushed
the
eng/The-CSSPropertyNames-cpp-file-is-code-generated-with-non-deterministic-contents
branch
from
2ae69d2 to
e4ff5df
Compare
|
Committed 252297@main (e4ff5df): https://commits.webkit.org/252297@main Reviewed commits have been landed. Closing PR #2196 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
akyrtzi
deleted the
eng/The-CSSPropertyNames-cpp-file-is-code-generated-with-non-deterministic-contents
branch
dpino
pushed a commit
to dpino/webkit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e4ff5df