querySelector() throws exception for -webkit-prefixed pseudo elements

[annevk]

a23b77e

querySelector() throws exception for -webkit-prefixed pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=149160
rdar://99299129

Reviewed by Antti Koivisto.

SelectorHasInvalidSelectorFunctor which is only used by querySelector()
and friends treated custom pseudo-elements as invalid. This is wrong.
querySelector("::placeholder") and querySelector("::-webkit-asdf") are
perfectly acceptable inputs, they are just supposed to return null.

Also do some minor code cleanup while in the general area.

Canonical link: https://commits.webkit.org/272337@main

de86f5a

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 27f9178)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[mdubet]

We should add a test (WPT ideally) for this

[Ahmad-S792]

We should add a test (WPT ideally) for this

Is this third test case about this? https://wpt.fyi/results/css/selectors/webkit-pseudo-element.html?label=master&label=experimental&aligned&q=webkit

[annevk]

It's a draft for a reason. 😉

[webkit-early-warning-system]

EWS run on current version of this PR (hash de86f5a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[annevk]

@anttijk should probably be a follow-up, but I wonder if this allows for even greater simplification as the notion of validity should now match that of CSS so presumably we can now reuse some code path that doesn't need for its own hasInvalidSelector().

[mdubet]

That would be a good opportunity to convert the whole functor class to a simple lambda.

[webkit-commit-queue]

Committed 272337@main (a23b77e): https://commits.webkit.org/272337@main

Reviewed commits have been landed. Closing PR #22038 and removing active labels.