Skip to content

Rename EventNames.in to EventInterfaces.in#22410

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
rniwa:fix267110
Jan 5, 2024
Merged

Rename EventNames.in to EventInterfaces.in#22410
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
rniwa:fix267110

Conversation

@rniwa
Copy link
Copy Markdown
Member

@rniwa rniwa commented Jan 5, 2024 •
edited by webkit-early-warning-system
Loading

70f75cd

Rename EventNames.in to EventInterfaces.in
https://bugs.webkit.org/show_bug.cgi?id=267110

Reviewed by Tim Nguyen.

Renamed EventNames.in to EventInterfaces.in to distinguish it from EventNames.h,
which is another CPP header file that defines the names of events.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/EventInterfaces.in: Renamed from Source/WebCore/dom/EventNames.in.

Canonical link: https://commits.webkit.org/272670@main

70e6b00

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
❌ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@rniwa rniwa self-assigned this Jan 5, 2024
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jan 5, 2024
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jan 5, 2024 •
edited
Loading

EWS run on previous version of this PR (hash b3345a5)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 gtk
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress
⏳ 🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 5, 2024
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Jan 5, 2024
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jan 5, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 02351ef)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
⏳ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 gtk
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🛠 tv-sim   🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
⏳ 🛠 watch ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jan 5, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 922d0ce)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

nt1m
nt1m approved these changes Jan 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

rniwa
rniwa commented Jan 5, 2024
View reviewed changes
Comment thread Source/WebCore/DerivedSources.make Outdated
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jan 5, 2024 •
edited
Loading

EWS run on current version of this PR (hash 70e6b00)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
❌ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 5, 2024
@rniwa
Rename EventNames.in to EventInterfaces.in
70f75cd 
https://bugs.webkit.org/show_bug.cgi?id=267110

Reviewed by Tim Nguyen.

Renamed EventNames.in to EventInterfaces.in to distinguish it from EventNames.h,
which is another CPP header file that defines the names of events.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/EventInterfaces.in: Renamed from Source/WebCore/dom/EventNames.in.

Canonical link: https://commits.webkit.org/272670@main
@webkit-commit-queue webkit-commit-queue merged commit 70f75cd into WebKit:main Jan 5, 2024
@rniwa rniwa deleted the fix267110 branch January 5, 2024 04:11
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Jan 5, 2024

Committed 272670@main (70f75cd): https://commits.webkit.org/272670@main

Reviewed commits have been landed. Closing PR #22410 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@Constellation Constellation Awaiting requested review from Constellation

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@rniwa rniwa

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @nt1m @webkit-ews-buildbot