Save linked subresources when saving web page resources

[szewai]

f006d3e

Save linked subresources when saving web page resources
https://bugs.webkit.org/show_bug.cgi?id=267372
rdar://120491493

Reviewed by Ryosuke Niwa and BJ Burg.

When collecting subresources URLs, we should include URL of link element if it is a link to external resource
(https://html.spec.whatwg.org/multipage/links.html#linkTypes), and it may fetch or cache the linked resource
(https://html.spec.whatwg.org/multipage/semantics.html#fetching-and-processing-a-resource-from-a-link-element). We
currently only include URL of style sheet.

Update API test: WebArchive.SaveResourcesLink

* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::mayFetchResource):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/272925@main

3b82ed3

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 tv	🧪 mac-AS-debug-wk2	🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 409a0c3)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	🧪 mac-wk2	🧪 gtk-wk2
	🛠 tv	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	🛠 tv-sim
	🛠 watch
	✅ 🛠 watch-sim

[burg]

Naming suggestion: linksToExternalResource(attr)

[szewai]

Based on @rniwa's comment, It seems we only need to collect URLs for subresources that may be fetched based on https://html.spec.whatwg.org/multipage/semantics.html#fetching-and-processing-a-resource-from-a-link-element, so I updated this to mayFetchResource. Let me know if you think there is better naming for this.

[rniwa]

We shouldn't need to do prefetch or preconnect either

[szewai]

It seems prefetch could request the resource (LinkLoader::prefetchIfNeeded) but preconnect and DNSPrefetch do not, so I removed reconnect and DNSPrefetch from the list.

[rniwa]

Well, prefetch COULD request the resource but the effect isn't script observable so we don't need to do it.

[szewai]

Ok, removed

[rniwa]

r=me with comments.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash b34ef4a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 gtk
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	⏳ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	❌ 🛠 watch-sim

[webkit-early-warning-system]

Starting EWS tests for 4e64621. Live statuses available at the PR page, #22623

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 4e64621)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 3b82ed3)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 tv	🧪 mac-AS-debug-wk2	🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 272925@main (f006d3e): https://commits.webkit.org/272925@main

Reviewed commits have been landed. Closing PR #22623 and removing active labels.