Skip to content

Reduce use of downcast<>() in ReferencedSVGResources.cpp#22740

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:267482_ReferencedSVGResources_fewer_downcast
Jan 13, 2024
Merged

Reduce use of downcast<>() in ReferencedSVGResources.cpp#22740
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:267482_ReferencedSVGResources_fewer_downcast

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 13, 2024 •
edited by webkit-early-warning-system
Loading

88e1d8e

Reduce use of downcast<>() in ReferencedSVGResources.cpp
https://bugs.webkit.org/show_bug.cgi?id=267482

Reviewed by Ryosuke Niwa.

* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedSVGResourceIDs):
(WebCore::ReferencedSVGResources::elementForResourceID):
(WebCore::ReferencedSVGResources::elementForResourceIDs):
* Source/WebCore/rendering/ReferencedSVGResources.h:

Canonical link: https://commits.webkit.org/273015@main

bd6c223

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jan 13, 2024
@cdumez cdumez added the SVG For bugs in the SVG implementation. label Jan 13, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 13, 2024 •
edited
Loading

EWS run on current version of this PR (hash bd6c223)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 13, 2024
@cdumez
Reduce use of downcast<>() in ReferencedSVGResources.cpp
88e1d8e 
https://bugs.webkit.org/show_bug.cgi?id=267482

Reviewed by Ryosuke Niwa.

* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedSVGResourceIDs):
(WebCore::ReferencedSVGResources::elementForResourceID):
(WebCore::ReferencedSVGResources::elementForResourceIDs):
* Source/WebCore/rendering/ReferencedSVGResources.h:

Canonical link: https://commits.webkit.org/273015@main
@webkit-commit-queue webkit-commit-queue force-pushed the 267482_ReferencedSVGResources_fewer_downcast branch from bd6c223 to 88e1d8e Compare January 13, 2024 22:50
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 13, 2024

Committed 273015@main (88e1d8e): https://commits.webkit.org/273015@main

Reviewed commits have been landed. Closing PR #22740 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 88e1d8e into WebKit:main Jan 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rniwa rniwa rniwa approved these changes

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

@shallawa shallawa Awaiting requested review from shallawa

Assignees

@cdumez cdumez

Labels

SVG For bugs in the SVG implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa

Comments