Skip to content

[jsc] Don't include --reprl in help text if Fuzzilli is not enabled #22877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

[jsc] Don't include --reprl in help text if Fuzzilli is not enabled #22877

merged 1 commit into from
Jan 17, 2024

Conversation

@ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented Jan 17, 2024 •
edited by webkit-early-warning-system
Loading

836ec03

[jsc] Don't include --reprl in help text if Fuzzilli is not enabled
https://bugs.webkit.org/show_bug.cgi?id=267652
<rdar://121133500>

Reviewed by Mark Lam.

* Source/JavaScriptCore/jsc.cpp:
(printUsageStatement):
- Add #if ENABLE(FUZZILLI)/#endif around --reprl switch.

Canonical link: https://commits.webkit.org/273144@main

03dc9f9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 gtk
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ❌ 🧪 gtk-wk2
  🛠 🧪 jsc-arm64   🛠 tv   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
  🛠 tv-sim   🛠 jsc-armv7
  🛠 watch   🧪 jsc-armv7-tests
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@ddkilzer ddkilzer requested a review from a team as a code owner January 17, 2024 21:47
@ddkilzer ddkilzer self-assigned this Jan 17, 2024
@ddkilzer ddkilzer added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jan 17, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 17, 2024 •
edited
Loading

EWS run on current version of this PR (hash 03dc9f9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 gtk
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ❌ 🧪 gtk-wk2
  🛠 🧪 jsc-arm64   🛠 tv   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
  🛠 tv-sim   🛠 jsc-armv7
  🛠 watch   🧪 jsc-armv7-tests
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@ddkilzer ddkilzer requested a review from MenloDorian January 17, 2024 21:49
MenloDorian
MenloDorian approved these changes Jan 17, 2024
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 17, 2024
@ddkilzer
[jsc] Don't include --reprl in help text if Fuzzilli is not enabled
836ec03 
https://bugs.webkit.org/show_bug.cgi?id=267652
<rdar://121133500>

Reviewed by Mark Lam.

* Source/JavaScriptCore/jsc.cpp:
(printUsageStatement):
- Add #if ENABLE(FUZZILLI)/#endif around --reprl switch.

Canonical link: https://commits.webkit.org/273144@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/jsc-Dont-include---reprl-in-help-text-if-Fuzzilli-is-not-enabled branch from 03dc9f9 to 836ec03 Compare January 17, 2024 21:56
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 17, 2024

Committed 273144@main (836ec03): https://commits.webkit.org/273144@main

Reviewed commits have been landed. Closing PR #22877 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 836ec03 into WebKit:main Jan 17, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 17, 2024
@ddkilzer ddkilzer deleted the eng/jsc-Dont-include---reprl-in-help-text-if-Fuzzilli-is-not-enabled branch January 17, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@ddkilzer ddkilzer

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddkilzer @webkit-early-warning-system @webkit-commit-queue @MenloDorian