Skip to content

Increase adoption of dynamicDowncast<Document>#23048

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Increase-adoption-of-dynamicDowncastDocument
Jan 23, 2024
Merged

Increase adoption of dynamicDowncast<Document>#23048
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Increase-adoption-of-dynamicDowncastDocument

Conversation

@annevk
Copy link
Contributor

@annevk annevk commented Jan 22, 2024 •
edited by webkit-early-warning-system
Loading

ea8a714

Increase adoption of dynamicDowncast<Document>
https://bugs.webkit.org/show_bug.cgi?id=267861

Reviewed by Chris Dumez.

And cleanup some nearby code while there.

* Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::computeIntersectionState const):
(WebCore::IntersectionObserver::nowTimestamp const):
* Source/WebCore/page/NavigatorBase.cpp:
* Source/WebCore/page/PerformanceMark.cpp:
(WebCore::performanceNow):
* Source/WebCore/page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::PerformanceObserver):
(WebCore::PerformanceObserver::supportedEntryTypes):
* Source/WebCore/page/PerformanceUserTiming.cpp:
(WebCore::PerformanceUserTiming::mark):
* Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::willSettleRegistrationPromise):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):
(WebCore::ServiceWorkerContainer::contextIdentifier):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::prepareToSend):

Canonical link: https://commits.webkit.org/273378@main

346e01b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jan 22, 2024
@annevk annevk added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 22, 2024
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2024
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jan 23, 2024
@annevk annevk force-pushed the eng/Increase-adoption-of-dynamicDowncastDocument branch from 295b1bb to 0b15b96 Compare January 23, 2024 12:49
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
annevk
annevk commented Jan 23, 2024
View reviewed changes
@annevk annevk marked this pull request as ready for review January 23, 2024 14:26
@annevk annevk requested a review from cdumez as a code owner January 23, 2024 14:26
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 23, 2024
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jan 23, 2024
cdumez
cdumez approved these changes Jan 23, 2024
View reviewed changes
@annevk annevk force-pushed the eng/Increase-adoption-of-dynamicDowncastDocument branch from 0b15b96 to 346e01b Compare January 23, 2024 17:52
@webkit-early-warning-system

This comment was marked as duplicate.

Sign in to view
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 23, 2024 •
edited
Loading

EWS run on current version of this PR (hash 346e01b)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 23, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 23, 2024
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Jan 23, 2024

Safe-Merge-Queue: Build #10072.

@annevk
Increase adoption of dynamicDowncast<Document>
ea8a714 
https://bugs.webkit.org/show_bug.cgi?id=267861

Reviewed by Chris Dumez.

And cleanup some nearby code while there.

* Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::computeIntersectionState const):
(WebCore::IntersectionObserver::nowTimestamp const):
* Source/WebCore/page/NavigatorBase.cpp:
* Source/WebCore/page/PerformanceMark.cpp:
(WebCore::performanceNow):
* Source/WebCore/page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::PerformanceObserver):
(WebCore::PerformanceObserver::supportedEntryTypes):
* Source/WebCore/page/PerformanceUserTiming.cpp:
(WebCore::PerformanceUserTiming::mark):
* Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::willSettleRegistrationPromise):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):
(WebCore::ServiceWorkerContainer::contextIdentifier):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::prepareToSend):

Canonical link: https://commits.webkit.org/273378@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Increase-adoption-of-dynamicDowncastDocument branch from 346e01b to ea8a714 Compare January 23, 2024 22:38
@webkit-commit-queue webkit-commit-queue merged commit ea8a714 into WebKit:main Jan 23, 2024
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 23, 2024

Committed 273378@main (ea8a714): https://commits.webkit.org/273378@main

Reviewed commits have been landed. Closing PR #23048 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 23, 2024
@annevk annevk deleted the eng/Increase-adoption-of-dynamicDowncastDocument branch January 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@annevk annevk

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@annevk @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @cdumez