Make sure simulators have correct bundle ID#23128
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jan 24, 2024
Merged
Make sure simulators have correct bundle ID#23128webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
pvollan
added
the
WebKit Misc.
Collaborator
|
EWS run on current version of this PR (hash 00bb5bd) Details
|
brentfulgham
approved these changes
Jan 24, 2024
Contributor
brentfulgham
left a comment
brentfulgham
left a comment
There was a problem hiding this comment.
I should have noticed this in the earlier patch. Thank you for fixing. r=me
Contributor
Author
Thanks for reviewing! |
https://bugs.webkit.org/show_bug.cgi?id=267964 rdar://121474403 Reviewed by Brent Fulgham. Make sure simulators have correct bundle ID for all platforms. * Source/WebKit/Configurations/GPUService.xcconfig: * Source/WebKit/Configurations/NetworkService.xcconfig: * Source/WebKit/Configurations/WebContentService.xcconfig: Canonical link: https://commits.webkit.org/273388@main
webkit-commit-queue
force-pushed
the
eng/Make-sure-simulators-have-correct-bundle-ID
branch
from
00bb5bd to
9a9aef3
Compare
Collaborator
|
Committed 273388@main (9a9aef3): https://commits.webkit.org/273388@main Reviewed commits have been landed. Closing PR #23128 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9a9aef3
00bb5bd
🧪 wpe-wk2🛠 tv-sim🛠 watch-sim