Skip to content

[iOS] Embedded twitter video controls are too tiny and don't prevent scrolling in fullscreen#23193

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
jernoble:eng/iOS-Embedded-twitter-video-controls-are-too-tiny-and-dont-prevent-scrolling-in-fullscreen
Jan 25, 2024
Merged

[iOS] Embedded twitter video controls are too tiny and don't prevent scrolling in fullscreen#23193
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
jernoble:eng/iOS-Embedded-twitter-video-controls-are-too-tiny-and-dont-prevent-scrolling-in-fullscreen

Conversation

@jernoble
Copy link
Copy Markdown
Contributor

@jernoble jernoble commented Jan 24, 2024

37100c1

[iOS] Embedded twitter video controls are too tiny and don't prevent scrolling in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=268031
rdar://121473410

Reviewed by Eric Carlson.

Add a quirk to disable element fullscreen for twitter.com embeds.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::isEmbedDomain const):
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/273519@main

d98126a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble requested a review from cdumez as a code owner January 24, 2024 21:57
@jernoble jernoble self-assigned this Jan 24, 2024
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Jan 24, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 25, 2024
@jernoble jernoble added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 25, 2024
…scrolling in fullscreen

https://bugs.webkit.org/show_bug.cgi?id=268031
rdar://121473410

Reviewed by Eric Carlson.

Add a quirk to disable element fullscreen for twitter.com embeds.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::isEmbedDomain const):
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/273519@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/iOS-Embedded-twitter-video-controls-are-too-tiny-and-dont-prevent-scrolling-in-fullscreen branch from d98126a to 37100c1 Compare January 25, 2024 18:46
@webkit-commit-queue webkit-commit-queue merged commit 37100c1 into WebKit:main Jan 25, 2024
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 273519@main (37100c1): https://commits.webkit.org/273519@main

Reviewed commits have been landed. Closing PR #23193 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants