Skip to content

Adopt more smart pointers in ResourceLoader.cpp#23220

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:268054_ResourceLoader_smart_pointers
Jan 25, 2024
Merged

Adopt more smart pointers in ResourceLoader.cpp#23220
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:268054_ResourceLoader_smart_pointers

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 25, 2024

578277a

Adopt more smart pointers in ResourceLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=268054

Reviewed by Ryosuke Niwa.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::protectedNetworkingContext const):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::finishNetworkLoad):
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::setDefersLoading):
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::willSwitchToSubstituteResource):
(WebCore::ResourceLoader::checkedFrameLoader const):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::logResourceResponseSource):
(WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const):
(WebCore::ResourceLoader::didBlockAuthenticationChallenge):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveBuffer):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::cleanupForError):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::cancelledError):
(WebCore::ResourceLoader::blockedError):
(WebCore::ResourceLoader::blockedByContentBlockerError):
(WebCore::ResourceLoader::cannotShowURLError):
(WebCore::ResourceLoader::httpsUpgradeRedirectLoopError):
(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::didReceiveResponseAsync):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceLoader::connectionProperties):
(WebCore::ResourceLoader::schedule):
(WebCore::ResourceLoader::unschedule):
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
* Source/WebCore/loader/ResourceLoader.h:

Canonical link: https://commits.webkit.org/273478@main

0d99400

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 🧪 gtk-wk2
✅ 🛠 tv 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jan 25, 2024
@cdumez cdumez added the Page Loading For bugs in page loading, including handling of network callbacks. label Jan 25, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 25, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Jan 25, 2024
@cdumez cdumez force-pushed the 268054_ResourceLoader_smart_pointers branch from 2010e95 to 0d99400 Compare January 25, 2024 03:38
@cdumez cdumez marked this pull request as ready for review January 25, 2024 05:45
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2024
https://bugs.webkit.org/show_bug.cgi?id=268054

Reviewed by Ryosuke Niwa.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::protectedNetworkingContext const):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::finishNetworkLoad):
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::setDefersLoading):
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::willSwitchToSubstituteResource):
(WebCore::ResourceLoader::checkedFrameLoader const):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::logResourceResponseSource):
(WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const):
(WebCore::ResourceLoader::didBlockAuthenticationChallenge):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveBuffer):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::cleanupForError):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::cancelledError):
(WebCore::ResourceLoader::blockedError):
(WebCore::ResourceLoader::blockedByContentBlockerError):
(WebCore::ResourceLoader::cannotShowURLError):
(WebCore::ResourceLoader::httpsUpgradeRedirectLoopError):
(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::didReceiveResponseAsync):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceLoader::connectionProperties):
(WebCore::ResourceLoader::schedule):
(WebCore::ResourceLoader::unschedule):
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
* Source/WebCore/loader/ResourceLoader.h:

Canonical link: https://commits.webkit.org/273478@main
@webkit-commit-queue webkit-commit-queue force-pushed the 268054_ResourceLoader_smart_pointers branch from 0d99400 to 578277a Compare January 25, 2024 07:13
@webkit-commit-queue
Copy link
Collaborator

Committed 273478@main (578277a): https://commits.webkit.org/273478@main

Reviewed commits have been landed. Closing PR #23220 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 578277a into WebKit:main Jan 25, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Page Loading For bugs in page loading, including handling of network callbacks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants