Generate serialization for CFCharacterSetRef #23470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascoej
added
the
WebKit Misc.
pascoej
force-pushed
the
eng/Generate-serialization-for-CFCharacterSetRef
branch
from
a1f1c63 to
bf1bed9
Compare
Collaborator
|
EWS run on previous version of this PR (hash a1f1c63) Details
|
Collaborator
|
EWS run on previous version of this PR (hash bf1bed9) Details
|
achristensen07
approved these changes
Jan 31, 2024
Contributor
achristensen07
left a comment
achristensen07
left a comment
There was a problem hiding this comment.
r=me after 2 comments addressed.
Contributor
There was a problem hiding this comment.
I don't think we should add any RELEASE_ASSERTs.
pascoej
force-pushed
the
eng/Generate-serialization-for-CFCharacterSetRef
branch
from
bf1bed9 to
c946f49
Compare
Collaborator
|
EWS run on previous version of this PR (hash c946f49) Details
|
webkit-ews-buildbot
added
the
merging-blocked
pascoej
force-pushed
the
eng/Generate-serialization-for-CFCharacterSetRef
branch
from
c946f49 to
6b17a19
Compare
Collaborator
|
EWS run on previous version of this PR (hash 6b17a19) Details
|
🧪 gtk-wk2
webkit-ews-buildbot
added
the
merging-blocked
pascoej
force-pushed
the
eng/Generate-serialization-for-CFCharacterSetRef
branch
from
6b17a19 to
94a8e17
Compare
Collaborator
|
EWS run on current version of this PR (hash 94a8e17) Details
|
https://bugs.webkit.org/show_bug.cgi?id=268338 rdar://121884571 Reviewed by Alex Christensen. This patch moves from using a hand-rolled serializer for CFCharacterSetRef to a generated one and expands a test to exercise it. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::ArgumentCoder<CFCharacterSetRef>::encode): Deleted. (IPC::ArgumentCoder<RetainPtr<CFCharacterSetRef>>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (TEST): Canonical link: https://commits.webkit.org/274177@main
webkit-commit-queue
force-pushed
the
eng/Generate-serialization-for-CFCharacterSetRef
branch
from
94a8e17 to
2b8626d
Compare
Collaborator
|
Committed 274177@main (2b8626d): https://commits.webkit.org/274177@main Reviewed commits have been landed. Closing PR #23470 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2b8626d
94a8e17
🧪 bindings🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 mac-wk2