Add some tests that decide to download after an HTTP redirection#23486
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jan 31, 2024
Conversation
achristensen07
added
the
WebKit Process Model
Collaborator
|
EWS run on previous version of this PR (hash 8c97d89) Details
|
charliewolfe
approved these changes
Jan 30, 2024
Member
There was a problem hiding this comment.
WKDownload * doesn't need the variable name.
achristensen07
force-pushed
the
eng/Add-some-tests-that-decide-to-download-after-an-HTTP-redirection
branch
from
8c97d89 to
a42d6a1
Compare
Collaborator
|
EWS run on previous version of this PR (hash a42d6a1) Details |
achristensen07
force-pushed
the
eng/Add-some-tests-that-decide-to-download-after-an-HTTP-redirection
branch
from
a42d6a1 to
d3959fc
Compare
Collaborator
|
EWS run on current version of this PR (hash d3959fc) Details
|
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268350 rdar://121891934 Reviewed by Charlie Wolfe. Choosing to download only after seeing a redirect response is a case that has no tests. It currently uses much of the same code paths as choosing to download when initially seeing a navigation action, but with some upcoming work I'm planning to make them different code paths, so it's important to add a test for this case to verify existing behavior does not change. * Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm: (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]): (-[TestNavigationDelegate webView:navigationAction:didBecomeDownload:]): (-[TestNavigationDelegate webView:navigationResponse:didBecomeDownload:]): Canonical link: https://commits.webkit.org/273854@main
webkit-commit-queue
force-pushed
the
eng/Add-some-tests-that-decide-to-download-after-an-HTTP-redirection
branch
from
d3959fc to
33d8a41
Compare
Collaborator
|
Committed 273854@main (33d8a41): https://commits.webkit.org/273854@main Reviewed commits have been landed. Closing PR #23486 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
33d8a41
d3959fc
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🛠 gtk🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim