Skip to content

Adopt dynamicDowncast<> in editing's HTMLConverter #23565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Feb 1, 2024
Merged

Adopt dynamicDowncast<> in editing's HTMLConverter #23565

webkit-commit-queue merged 1 commit into from
Feb 1, 2024

Conversation

@annevk
Copy link
Contributor

@annevk annevk commented Jan 31, 2024 •
edited by webkit-early-warning-system
Loading

65b42b7

Adopt dynamicDowncast<> in editing's HTMLConverter
https://bugs.webkit.org/show_bug.cgi?id=268442

Reviewed by Chris Dumez.

* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::inlineStylePropertyForElement):
(stringFromCSSValue):
(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverterCaches::colorPropertyValueForNode):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_traverseNode):
(fileWrapperForElement):
(WebCore::editingAttributedString):

Canonical link: https://commits.webkit.org/273881@main

381ce98

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jan 31, 2024
@annevk annevk added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 31, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 31, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a4e255d)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk marked this pull request as ready for review January 31, 2024 13:35
@annevk annevk requested a review from rniwa as a code owner January 31, 2024 13:35
@annevk annevk requested a review from cdumez January 31, 2024 13:35
annevk
annevk commented Jan 31, 2024
View reviewed changes
cdumez
cdumez approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

@annevk annevk force-pushed the eng/Adopt-dynamicDowncast-in-editings-HTMLConverter branch from a4e255d to d3bb522 Compare January 31, 2024 17:54
cdumez
cdumez approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 31, 2024 •
edited
Loading

EWS run on previous version of this PR (hash d3bb522)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk force-pushed the eng/Adopt-dynamicDowncast-in-editings-HTMLConverter branch from d3bb522 to 381ce98 Compare January 31, 2024 18:43
@annevk annevk added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 31, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 31, 2024 •
edited
Loading

EWS run on current version of this PR (hash 381ce98)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 1, 2024
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Feb 1, 2024

Safe-Merge-Queue: Build #10853.

@annevk
Adopt dynamicDowncast<> in editing's HTMLConverter
65b42b7 
https://bugs.webkit.org/show_bug.cgi?id=268442

Reviewed by Chris Dumez.

* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::inlineStylePropertyForElement):
(stringFromCSSValue):
(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverterCaches::colorPropertyValueForNode):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_traverseNode):
(fileWrapperForElement):
(WebCore::editingAttributedString):

Canonical link: https://commits.webkit.org/273881@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-dynamicDowncast-in-editings-HTMLConverter branch from 381ce98 to 65b42b7 Compare February 1, 2024 02:58
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Feb 1, 2024

Committed 273881@main (65b42b7): https://commits.webkit.org/273881@main

Reviewed commits have been landed. Closing PR #23565 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 65b42b7 into WebKit:main Feb 1, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 1, 2024
@annevk annevk deleted the eng/Adopt-dynamicDowncast-in-editings-HTMLConverter branch February 1, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@annevk annevk

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@annevk @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @cdumez