Fix sandbox compilation error related to empty parameters#24004
Merged
webkit-commit-queue merged 1 commit intoFeb 7, 2024
Conversation
pvollan
added
the
WebKit Misc.
Collaborator
|
EWS run on previous version of this PR (hash eadab98) Details |
webkit-ews-buildbot
added
the
merging-blocked
pvollan
force-pushed
the
eng/Fix-sandbox-compilation-error-related-to-empty-parameters
branch
from
eadab98 to
8196365
Compare
Collaborator
|
EWS run on current version of this PR (hash 8196365) Details
|
brentfulgham
approved these changes
Feb 7, 2024
Contributor
brentfulgham
left a comment
brentfulgham
left a comment
There was a problem hiding this comment.
Do we have a similar possibility for any of the other sandboxes?
r=me
Contributor
Author
Thanks for reviewing! |
Contributor
Author
That is a good point. This length check is already present in the other sandboxes. Thanks for reviewing! |
https://bugs.webkit.org/show_bug.cgi?id=268916 rdar://88915314 Reviewed by David Kilzer and Brent Fulgham. On rare occasions, see https://bugs.webkit.org/show_bug.cgi?id=222233 for more details, the sandbox string parameters provided to the Networking process' sandbox can be empty. This will cause the compilation of the sandbox to fail, and the Networking process will crash on startup being unable to apply the sandbox. We can guard against this in the sandbox by checking the string length of the parameters. We already do this for the GPU process and WebContent process. * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Canonical link: https://commits.webkit.org/274228@main
webkit-commit-queue
force-pushed
the
eng/Fix-sandbox-compilation-error-related-to-empty-parameters
branch
from
8196365 to
3fb7287
Compare
Collaborator
|
Committed 274228@main (3fb7287): https://commits.webkit.org/274228@main Reviewed commits have been landed. Closing PR #24004 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3fb7287
8196365
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🛠 watch