Skip to content

Remove unused m_isActive private field in MockSourceBufferPrivate #24077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Feb 9, 2024
Merged

Remove unused m_isActive private field in MockSourceBufferPrivate #24077

webkit-commit-queue merged 1 commit into from
Feb 9, 2024

Conversation

@blino
Copy link
Contributor

@blino blino commented Feb 8, 2024 •
edited by webkit-early-warning-system
Loading

3c2fd51

Remove unused m_isActive private field in MockSourceBufferPrivate
https://bugs.webkit.org/show_bug.cgi?id=268991

Reviewed by Sihui Liu.

Since 270354@main (e25a76a60507), the m_isActive private field is
unused in MockSourceBufferPrivate.

* Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h:

Canonical link: https://commits.webkit.org/274350@main

56ad670

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino self-assigned this Feb 8, 2024
@blino blino added the Media Bugs related to the HTML 5 Media elements. label Feb 8, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 8, 2024 •
edited
Loading

EWS run on current version of this PR (hash 56ad670)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@blino blino requested review from jernoble and jyavenard February 8, 2024 16:56
@blino blino added the merge-queue Applied to send a pull request to merge-queue label Feb 9, 2024
@blino
Remove unused m_isActive private field in MockSourceBufferPrivate
3c2fd51 
https://bugs.webkit.org/show_bug.cgi?id=268991

Reviewed by Sihui Liu.

Since 270354@main (e25a76a), the m_isActive private field is
unused in MockSourceBufferPrivate.

* Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h:

Canonical link: https://commits.webkit.org/274350@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-unused-m_isActive-private-field-in-MockSourceBufferPrivate branch from 56ad670 to 3c2fd51 Compare February 9, 2024 08:37
@webkit-commit-queue webkit-commit-queue merged commit 3c2fd51 into WebKit:main Feb 9, 2024
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Feb 9, 2024

Committed 274350@main (3c2fd51): https://commits.webkit.org/274350@main

Reviewed commits have been landed. Closing PR #24077 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szewai szewai szewai approved these changes

@jyavenard jyavenard Awaiting requested review from jyavenard

@jernoble jernoble Awaiting requested review from jernoble

Assignees

@blino blino

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blino @webkit-early-warning-system @webkit-commit-queue @szewai