Move VKCImageAnalysis deserialization away from other NSObject deserializers #24275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit Misc.
|
EWS run on previous version of this PR (hash 0efc39b)
|
achristensen07
force-pushed
the
eng/Move-VKCImageAnalysis-deserialization-away-from-other-NSObject-deserializers
branch
from
0efc39b to
be07827
Compare
|
EWS run on current version of this PR (hash be07827)
|
achristensen07
added
unsafe-merge-queue
achristensen07
force-pushed
the
eng/Move-VKCImageAnalysis-deserialization-away-from-other-NSObject-deserializers
branch
from
be07827 to
19af88b
Compare
achristensen07
added
unsafe-merge-queue
…alizers https://bugs.webkit.org/show_bug.cgi?id=269230 rdar://122825380 Reviewed by Wenson Hsieh. It is currently the only ObjC object that is deserialized from IPC without _enableStrictSecureDecodingMode, which is less urgent because it is only sent from the trusted UI process to the untrusted web content process. This PR just moves that logic away from the rest of the IPC logic and adds a release assertion to make sure we don't introduce a security issue in the future. * Source/WebCore/platform/TextRecognitionResult.h: * Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm: (WebCore::TextRecognitionResult::encodeVKCImageAnalysis): (WebCore::TextRecognitionResult::decodeVKCImageAnalysis): (WebCore::stringForRange): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::installImageOverlay): * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm: (WebKit::makeTextRecognitionResult): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::getClass<VKCImageAnalysis>): Deleted. (IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::encode): Deleted. (IPC::ArgumentCoder<RetainPtr<VKCImageAnalysis>>::decode): Deleted. * Source/WebKit/Shared/TextRecognitionResult.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.h: Canonical link: https://commits.webkit.org/274495@main
webkit-commit-queue
force-pushed
the
eng/Move-VKCImageAnalysis-deserialization-away-from-other-NSObject-deserializers
branch
from
19af88b to
272b9be
Compare
|
Committed 274495@main (272b9be): https://commits.webkit.org/274495@main Reviewed commits have been landed. Closing PR #24275 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
272b9be
19af88b
🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 gtk🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 watch-sim