Skip to content

Conversation

@aoikonomopoulos
Copy link
Contributor

@aoikonomopoulos aoikonomopoulos commented Feb 14, 2024

1da9e9d

Set DeletingAllowed for bmalloc::Heap::m_largeAllocated
https://bugs.webkit.org/show_bug.cgi?id=269357

Reviewed by Michael Saboff.

https://commits.webkit.org/274606@main added an AllowDeleting parameter
to bmalloc::Map, which defaults to DeletingNotAllowed. However, this
default does not work for the Map in bmalloc/Heap.h, leading to massive
JSC breakage on platforms that haven't switched to libpas. Set it to
DeletingAllowed instead.

* Source/bmalloc/bmalloc/Heap.h:

Canonical link: https://commits.webkit.org/274644@main

823f94b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@aoikonomopoulos aoikonomopoulos self-assigned this Feb 14, 2024
@aoikonomopoulos aoikonomopoulos added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 14, 2024
Copy link
Contributor

@msaboff msaboff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that.
LGTM
r+

@jjgriego jjgriego added the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=269357

Reviewed by Michael Saboff.

https://commits.webkit.org/274606@main added an AllowDeleting parameter
to bmalloc::Map, which defaults to DeletingNotAllowed. However, this
default does not work for the Map in bmalloc/Heap.h, leading to massive
JSC breakage on platforms that haven't switched to libpas. Set it to
DeletingAllowed instead.

* Source/bmalloc/bmalloc/Heap.h:

Canonical link: https://commits.webkit.org/274644@main
@webkit-commit-queue
Copy link
Collaborator

Committed 274644@main (1da9e9d): https://commits.webkit.org/274644@main

Reviewed commits have been landed. Closing PR #24409 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1da9e9d into WebKit:main Feb 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants