[WGSL] Validate element types of vectors, matrices and textures#24429
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 15, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash c235550) Details
|
mwyrzykowski
approved these changes
Feb 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=269379 rdar://122293433 Reviewed by Mike Wyrzykowski. Validate that the element type of each of these type generators is valid according to the spec: - vectors can only contain scalar types - matrices can only contain floating point types - a texture's sampled type must be a concrete 32 bit scalar (i32, u32 or f32) * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::TypeChecker): (WGSL::TypeChecker::allocateSimpleConstructor): Canonical link: https://commits.webkit.org/274714@main
c235550 to
0babce1
Compare
Collaborator
|
Committed 274714@main (0babce1): https://commits.webkit.org/274714@main Reviewed commits have been landed. Closing PR #24429 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0babce1
c235550