Skip to content

[WGSL] Validate element types of vectors, matrices and textures#24429

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Validate-element-types-of-vectors-matrices-and-textures
Feb 15, 2024
Merged

[WGSL] Validate element types of vectors, matrices and textures#24429
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Validate-element-types-of-vectors-matrices-and-textures

Conversation

@tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Feb 14, 2024

0babce1

[WGSL] Validate element types of vectors, matrices and textures
https://bugs.webkit.org/show_bug.cgi?id=269379
rdar://122293433

Reviewed by Mike Wyrzykowski.

Validate that the element type of each of these type generators is valid according
to the spec:
- vectors can only contain scalar types
- matrices can only contain floating point types
- a texture's sampled type must be a concrete 32 bit scalar (i32, u32 or f32)

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::TypeChecker):
(WGSL::TypeChecker::allocateSimpleConstructor):

Canonical link: https://commits.webkit.org/274714@main

c235550

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Feb 14, 2024
@tadeuzagallo tadeuzagallo requested a review from djg as a code owner February 14, 2024 18:20
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Feb 14, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=269379
rdar://122293433

Reviewed by Mike Wyrzykowski.

Validate that the element type of each of these type generators is valid according
to the spec:
- vectors can only contain scalar types
- matrices can only contain floating point types
- a texture's sampled type must be a concrete 32 bit scalar (i32, u32 or f32)

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::TypeChecker):
(WGSL::TypeChecker::allocateSimpleConstructor):

Canonical link: https://commits.webkit.org/274714@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Validate-element-types-of-vectors-matrices-and-textures branch from c235550 to 0babce1 Compare February 15, 2024 12:25
@webkit-commit-queue
Copy link
Collaborator

Committed 274714@main (0babce1): https://commits.webkit.org/274714@main

Reviewed commits have been landed. Closing PR #24429 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0babce1 into WebKit:main Feb 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants