[JSC] Use offlineasm globl to ensure that all entries have alt_entry #24569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
Collaborator
|
EWS run on current version of this PR (hash 5bc9553) Details |
Constellation
added
the
unsafe-merge-queue
webkit-commit-queue
force-pushed
the
eng/JSC-Use-offlineasm-globl-to-ensure-that-all-entries-have-alt_entry
branch
from
5bc9553 to
ef70151
Compare
https://bugs.webkit.org/show_bug.cgi?id=269534 rdar://122525586 Reviewed by Justin Michaud. We found that vmEntryToCSSJIT and vmEntryToCSSJITAfter are not having alt_entry properly since it is not using offlineasm globl. This allowed LLInt code shuffled by linkers when alt_entry is used, which breaks many assumptions. This patch fixes it. * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: Canonical link: https://commits.webkit.org/274796@main
webkit-commit-queue
force-pushed
the
eng/JSC-Use-offlineasm-globl-to-ensure-that-all-entries-have-alt_entry
branch
from
ef70151 to
be51d07
Compare
Collaborator
|
Committed 274796@main (be51d07): https://commits.webkit.org/274796@main Reviewed commits have been landed. Closing PR #24569 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Use-offlineasm-globl-to-ensure-that-all-entries-have-alt_entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be51d07
5bc9553
🛠 wincairo🧪 wpe-wk2🧪 api-wpe🧪 ios-wk2-wpt🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim