Migrate EventTarget to use EventTargetInterfaceType enum class instead of EventTargetInterface enum#24989
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 23, 2024
Merged
Conversation
rniwa
requested review from
aprotyas,
cdumez and
marcoscaceres
as code owners
rniwa
added
the
DOM
Collaborator
|
EWS run on previous version of this PR (hash 79c1bbb) Details
|
webkit-ews-buildbot
added
the
merging-blocked
Collaborator
|
EWS run on previous version of this PR (hash e790d74) Details
|
cdumez
approved these changes
Feb 23, 2024
webkit-ews-buildbot
added
the
merging-blocked
Collaborator
|
EWS run on current version of this PR (hash 1907ee4) Details |
rniwa
added
the
unsafe-merge-queue
…d of EventTargetInterface enum https://bugs.webkit.org/show_bug.cgi?id=269960 Reviewed by Chris Dumez. Moved EventTarget::eventTargetInterface from EventTargetInterface enum to EventTargetInterfaceType enum class. For now, we need to explicitly say "enum EventTargetInterfaceType" because there is an enum value of EventTargetInterfaceType in EventTargetInterface enum. * Source/WebCore/Modules/WebGPU/GPUDevice.h: * Source/WebCore/Modules/applepay/ApplePaySession.h: * Source/WebCore/Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::eventTargetInterface const): * Source/WebCore/Modules/async-clipboard/Clipboard.h: * Source/WebCore/Modules/audiosession/DOMAudioSession.h: * Source/WebCore/Modules/cookie-store/CookieStore.cpp: (WebCore::CookieStore::eventTargetInterface const): * Source/WebCore/Modules/cookie-store/CookieStore.h: * Source/WebCore/Modules/encryptedmedia/MediaKeySession.h: * Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h: * Source/WebCore/Modules/indexeddb/IDBDatabase.h: * Source/WebCore/Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::eventTargetInterface const): * Source/WebCore/Modules/indexeddb/IDBRequest.h: * Source/WebCore/Modules/indexeddb/IDBTransaction.h: * Source/WebCore/Modules/mediarecorder/MediaRecorder.h: * Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h: * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::eventTargetInterface const): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/Modules/mediasource/SourceBuffer.h: * Source/WebCore/Modules/mediasource/SourceBufferList.h: * Source/WebCore/Modules/mediastream/MediaDevices.h: * Source/WebCore/Modules/mediastream/MediaStream.h: * Source/WebCore/Modules/mediastream/MediaStreamTrack.h: * Source/WebCore/Modules/mediastream/RTCDTMFSender.h: * Source/WebCore/Modules/mediastream/RTCDataChannel.h: * Source/WebCore/Modules/mediastream/RTCDtlsTransport.h: * Source/WebCore/Modules/mediastream/RTCIceTransport.h: * Source/WebCore/Modules/mediastream/RTCPeerConnection.h: * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.h: * Source/WebCore/Modules/mediastream/RTCSctpTransport.h: * Source/WebCore/Modules/notifications/Notification.h: * Source/WebCore/Modules/paymentrequest/PaymentRequest.h: * Source/WebCore/Modules/paymentrequest/PaymentResponse.h: * Source/WebCore/Modules/permissions/PermissionStatus.h: * Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.h: * Source/WebCore/Modules/remoteplayback/RemotePlayback.h: * Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.h: * Source/WebCore/Modules/speech/SpeechRecognition.h: * Source/WebCore/Modules/speech/SpeechSynthesis.h: * Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h: * Source/WebCore/Modules/webaudio/AudioNode.cpp: (WebCore::AudioNode::eventTargetInterface const): * Source/WebCore/Modules/webaudio/AudioNode.h: * Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::eventTargetInterface const): * Source/WebCore/Modules/webaudio/BaseAudioContext.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h: * Source/WebCore/Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::eventTargetInterface const): * Source/WebCore/Modules/websockets/WebSocket.h: * Source/WebCore/Modules/webxr/WebXRLayer.h: * Source/WebCore/Modules/webxr/WebXRSession.h: * Source/WebCore/Modules/webxr/WebXRSpace.h: * Source/WebCore/Modules/webxr/WebXRSystem.h: * Source/WebCore/animation/WebAnimation.h: * Source/WebCore/bindings/scripts/InFilesCompiler.pm: (generateInterfacesHeader): * Source/WebCore/css/FontFaceSet.h: * Source/WebCore/css/MediaQueryList.h: * Source/WebCore/dom/AbortSignal.h: * Source/WebCore/dom/BroadcastChannel.h: * Source/WebCore/dom/EventTarget.h: * Source/WebCore/dom/EventTargetConcrete.h: * Source/WebCore/dom/EventTargetFactory.in: * Source/WebCore/dom/MessagePort.h: * Source/WebCore/dom/MouseRelatedEvent.cpp: * Source/WebCore/dom/MouseRelatedEvent.h: * Source/WebCore/dom/Node.cpp: (WebCore::Node::eventTargetInterface const): * Source/WebCore/dom/Node.h: * Source/WebCore/dom/make_event_factory.pl: (generateImplementation): * Source/WebCore/fileapi/FileReader.h: * Source/WebCore/html/MediaController.h: * Source/WebCore/html/OffscreenCanvas.h: * Source/WebCore/html/track/AudioTrackList.cpp: (WebCore::AudioTrackList::eventTargetInterface const): * Source/WebCore/html/track/AudioTrackList.h: * Source/WebCore/html/track/TextTrack.h: * Source/WebCore/html/track/TextTrackCue.h: * Source/WebCore/html/track/TextTrackList.cpp: (WebCore::TextTrackList::eventTargetInterface const): * Source/WebCore/html/track/TextTrackList.h: * Source/WebCore/html/track/TrackListBase.h: * Source/WebCore/html/track/VideoTrackList.cpp: (WebCore::VideoTrackList::eventTargetInterface const): * Source/WebCore/html/track/VideoTrackList.h: * Source/WebCore/loader/appcache/DOMApplicationCache.h: * Source/WebCore/page/DOMWindow.h: * Source/WebCore/page/EventSource.h: * Source/WebCore/page/LocalDOMWindow.h: (isType): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::eventTargetInterface const): * Source/WebCore/page/Navigation.h: * Source/WebCore/page/NavigationHistoryEntry.cpp: (WebCore::NavigationHistoryEntry::eventTargetInterface const): * Source/WebCore/page/NavigationHistoryEntry.h: * Source/WebCore/page/Performance.h: * Source/WebCore/page/ScreenOrientation.h: * Source/WebCore/page/VisualViewport.cpp: (WebCore::VisualViewport::eventTargetInterface const): * Source/WebCore/page/VisualViewport.h: * Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp: (WebCore::DedicatedWorkerGlobalScope::eventTargetInterface const): * Source/WebCore/workers/DedicatedWorkerGlobalScope.h: * Source/WebCore/workers/Worker.h: * Source/WebCore/workers/service/ServiceWorker.cpp: (WebCore::ServiceWorker::eventTargetInterface const): * Source/WebCore/workers/service/ServiceWorker.h: * Source/WebCore/workers/service/ServiceWorkerContainer.h: * Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp: (WebCore::ServiceWorkerGlobalScope::eventTargetInterface const): * Source/WebCore/workers/service/ServiceWorkerGlobalScope.h: * Source/WebCore/workers/service/ServiceWorkerRegistration.cpp: (WebCore::ServiceWorkerRegistration::eventTargetInterface const): * Source/WebCore/workers/service/ServiceWorkerRegistration.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchRegistration.h: * Source/WebCore/workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::eventTargetInterface const): * Source/WebCore/workers/shared/SharedWorker.h: * Source/WebCore/workers/shared/SharedWorkerGlobalScope.h: * Source/WebCore/worklets/WorkletGlobalScope.h: * Source/WebCore/xml/XMLHttpRequest.h: * Source/WebCore/xml/XMLHttpRequestUpload.h: Canonical link: https://commits.webkit.org/275233@main
webkit-commit-queue
force-pushed
the
fix269960
branch
from
1907ee4 to
ffdb8dd
Compare
Collaborator
|
Committed 275233@main (ffdb8dd): https://commits.webkit.org/275233@main Reviewed commits have been landed. Closing PR #24989 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffdb8dd
1907ee4
🧪 ios-wk2-wpt