[UnifiedPDF] Cursor updates are incorrect over text/image elements for untagged PDFs.#25064
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 24, 2024
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash c30baac) Details
|
hortont424
approved these changes
Feb 24, 2024
hortont424
reviewed
Feb 24, 2024
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Outdated
Show resolved
Hide resolved
hortont424
reviewed
Feb 24, 2024
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Outdated
Show resolved
Hide resolved
Collaborator
|
EWS run on current version of this PR (hash d5a5e06) Details
|
Member
Author
|
Thanks for the review! |
…r untagged PDFs. https://bugs.webkit.org/show_bug.cgi?id=265908 rdar://119217538 Reviewed by Tim Horton. The CGPDFPageLayoutGetAreaOfInterestAtPoint interface does not correctly identify text/image elements on Untagged PDF files. This made our hit test results incomplete on said PDF files. To address this issue, we adopt new PDFPage API `areaOfInterestAtPoint`, which not only hit tests for annotations, but also for text and image on a page, thus subsuming both -[PDFPage annotationAtPoint:] and CGPDFPageLayoutGetAreaOfInterestAtPoint while maintaining correctness across tagged and untagged PDFs. * Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const): Canonical link: https://commits.webkit.org/275287@main
d5a5e06 to
bcb2f89
Compare
Collaborator
|
Committed 275287@main (bcb2f89): https://commits.webkit.org/275287@main Reviewed commits have been landed. Closing PR #25064 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bcb2f89
d5a5e06