Skip to content

UnifiedPDF: Cursor hover shows for hidden pages#25185

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
hortont424:eng/UnifiedPDF-Cursor-hover-shows-for-hidden-pages
Feb 27, 2024
Merged

UnifiedPDF: Cursor hover shows for hidden pages#25185
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
hortont424:eng/UnifiedPDF-Cursor-hover-shows-for-hidden-pages

Conversation

@hortont424
Copy link
Contributor

@hortont424 hortont424 commented Feb 27, 2024

6f3f2d5

UnifiedPDF: Cursor hover shows for hidden pages
https://bugs.webkit.org/show_bug.cgi?id=270183
rdar://123192912

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
Don't handle mouse events on invisible pages. Reset the cursor to the default.

Canonical link: https://commits.webkit.org/275409@main

88e9fba

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@hortont424 hortont424 requested a review from cdumez as a code owner February 27, 2024 20:39
@hortont424 hortont424 self-assigned this Feb 27, 2024
@hortont424 hortont424 added the PDF For bugs in WebKit's built-in PDF support. label Feb 27, 2024
Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UnifiedPDF-Cursor-hover-shows-for-hidden-pages branch from 88e9fba to 6a4863d Compare February 27, 2024 22:29
https://bugs.webkit.org/show_bug.cgi?id=270183
rdar://123192912

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
Don't handle mouse events on invisible pages. Reset the cursor to the default.

Canonical link: https://commits.webkit.org/275409@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UnifiedPDF-Cursor-hover-shows-for-hidden-pages branch from 6a4863d to 6f3f2d5 Compare February 27, 2024 22:32
@webkit-commit-queue
Copy link
Collaborator

Committed 275409@main (6f3f2d5): https://commits.webkit.org/275409@main

Reviewed commits have been landed. Closing PR #25185 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6f3f2d5 into WebKit:main Feb 27, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PDF For bugs in WebKit's built-in PDF support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants