CredentialRequestOptions gains a "digital" member #25216

marcoscaceres · 2024-02-28T07:37:14Z

`3850dd4`

CredentialRequestOptions gains a "digital" member
https://bugs.webkit.org/show_bug.cgi?id=270196
rdar://123744112

Reviewed by Anne van Kesteren.

Adds "digital" member to CredentialRequestOptions dictionary:
https://wicg.github.io/digital-identities/#extensions-to-credentialrequestoptions-dictionary

Given the spec changed names again, changed pref name to DigitalIdentityEnabled and updated a few files to reflect the name change.

* LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https-expected.txt: Copied from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt.
* LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https.html: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html.
* LayoutTests/http/wpt/credential-management/setDigitalCreditialsEnable.https-expected.txt: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h:
* Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl:
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl:
* Source/WebCore/Modules/identity/Navigator+Identity.idl:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/275616@main

2211983

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-28T07:37:27Z

EWS run on previous version of this PR (hash 82a6e37)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-29T07:45:44Z

EWS run on previous version of this PR (hash c7a1eab)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 api-gtk
	~~🛠 tv-sim~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-29T07:51:09Z

EWS run on previous version of this PR (hash cbb2eeb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-29T08:35:18Z

EWS run on previous version of this PR (hash 20bb0a3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl

webkit-early-warning-system · 2024-03-01T01:54:31Z

EWS run on previous version of this PR (hash 460f3e8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-01T06:50:12Z

EWS run on previous version of this PR (hash 1165b35)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-04T04:05:34Z

EWS run on current version of this PR (hash 2211983)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

annevk · 2024-03-04T07:22:03Z

Source/WebCore/WebCore.xcodeproj/project.pbxproj

I don't understand why this file is changed as you're not changing any files. Seems best to leave out of this PR?

Those are needed to otherwise the DigitalCredentialRequestOptions.h doesn't end up in "private headers", and then it won't compile.

Oh I see, it wasn't included before. Okay.

https://bugs.webkit.org/show_bug.cgi?id=270196 rdar://123744112 Reviewed by Anne van Kesteren. Adds "digital" member to CredentialRequestOptions dictionary: https://wicg.github.io/digital-identities/#extensions-to-credentialrequestoptions-dictionary Given the spec changed names again, changed pref name to DigitalIdentityEnabled and updated a few files to reflect the name change. * LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https-expected.txt: Copied from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt. * LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https.html: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html. * LayoutTests/http/wpt/credential-management/setDigitalCreditialsEnable.https-expected.txt: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h: * Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl: * Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl: * Source/WebCore/Modules/identity/Navigator+Identity.idl: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275616@main

webkit-commit-queue · 2024-03-04T08:55:30Z

Committed 275616@main (3850dd4): https://commits.webkit.org/275616@main

Reviewed commits have been landed. Closing PR #25216 and removing active labels.

marcoscaceres self-assigned this Feb 28, 2024

marcoscaceres added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 28, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 28, 2024

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Feb 29, 2024

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from 82a6e37 to c7a1eab Compare February 29, 2024 07:45

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from c7a1eab to cbb2eeb Compare February 29, 2024 07:50

marcoscaceres marked this pull request as ready for review February 29, 2024 07:51

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from cbb2eeb to 20bb0a3 Compare February 29, 2024 08:35

marcoscaceres requested a review from whsieh February 29, 2024 08:38

annevk reviewed Feb 29, 2024

View reviewed changes

Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 29, 2024

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Mar 1, 2024

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from 20bb0a3 to 460f3e8 Compare March 1, 2024 01:54

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from 460f3e8 to 1165b35 Compare March 1, 2024 06:50

marcoscaceres requested a review from annevk March 1, 2024 06:50

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 1, 2024

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Mar 4, 2024

marcoscaceres force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from 1165b35 to 2211983 Compare March 4, 2024 04:05

annevk approved these changes Mar 4, 2024

View reviewed changes

marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2024

webkit-commit-queue force-pushed the eng/CredentialRequestOptions-gains-a-digital-member branch from 2211983 to 3850dd4 Compare March 4, 2024 08:55

webkit-commit-queue merged commit 3850dd4 into WebKit:main Mar 4, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2024

marcoscaceres deleted the eng/CredentialRequestOptions-gains-a-digital-member branch January 17, 2025 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CredentialRequestOptions gains a "digital" member #25216

CredentialRequestOptions gains a "digital" member #25216

Uh oh!

marcoscaceres commented Feb 28, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Feb 28, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 1, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 1, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 4, 2024 •

edited

Loading

Uh oh!

annevk Mar 4, 2024

Uh oh!

marcoscaceres Mar 4, 2024

Uh oh!

annevk Mar 4, 2024

Uh oh!

webkit-commit-queue commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CredentialRequestOptions gains a "digital" member #25216

CredentialRequestOptions gains a "digital" member #25216

Uh oh!

Conversation

marcoscaceres commented Feb 28, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

3850dd4

Uh oh!

webkit-early-warning-system commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

annevk Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

webkit-commit-queue commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcoscaceres commented Feb 28, 2024 •

edited by webkit-early-warning-system

Loading

`3850dd4`

webkit-early-warning-system commented Feb 28, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 29, 2024 •

edited

Loading

webkit-early-warning-system commented Mar 1, 2024 •

edited

Loading

webkit-early-warning-system commented Mar 1, 2024 •

edited

Loading

webkit-early-warning-system commented Mar 4, 2024 •

edited

Loading