-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Move ProcessThrottler to AuxiliaryProcessProxy #25315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
pvollan:eng/Move-ProcessThrottler-to-AuxiliaryProcessProxy
Mar 1, 2024
Merged
Move ProcessThrottler to AuxiliaryProcessProxy #25315
webkit-commit-queue
merged 1 commit into
WebKit:main
from
pvollan:eng/Move-ProcessThrottler-to-AuxiliaryProcessProxy
Mar 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
b3da4ad to
d260384
Compare
Collaborator
|
EWS run on previous version of this PR (hash d260384) Details
|
d260384 to
9495dcb
Compare
Collaborator
|
EWS run on current version of this PR (hash 9495dcb) Details
|
https://bugs.webkit.org/show_bug.cgi?id=269136 rdar://122708925 Reviewed by Chris Dumez. We can simplify the code by moving the ProcessThrottler object from every subclass to the AuxiliaryProcessProxy base class. This was previously landed in <https://commits.webkit.org/275195@main> and later reverted because it introduced a crash. The reason for the crash was that the ProcessThrottler was being deleted later since it moved to AuxiliaryProcessProxy. That could result in pure virtual function calls in the AuxiliaryProcessProxy destructor, since the ProcessThrottler calls virtual methods in AuxiliaryProcessProxy. This patch addresses this crash by calling didDisconnectFromProcess in AuxiliaryProcessProxy::shutDownProcess. * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::sendProcessDidResume): (WebKit::AuxiliaryProcessProxy::clientName const): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::throttler): * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: * Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp: (WebKit::ModelProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/Model/ModelProcessProxy.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching): * Source/WebKit/UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::throttler const): Deleted. Canonical link: https://commits.webkit.org/275528@main
9495dcb to
868e634
Compare
Collaborator
|
Committed 275528@main (868e634): https://commits.webkit.org/275528@main Reviewed commits have been landed. Closing PR #25315 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
868e634
9495dcb