build-and-collect-pgo-profiles script should be updated to use run-benchmarks' built-in HTTP server by default#25493
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 5, 2024
Conversation
xw
added
the
Tools / Tests
Collaborator
|
EWS run on current version of this PR (hash 8ce7bde) Details |
sundiamonde
approved these changes
Mar 5, 2024
…nchmarks' built-in HTTP server by default https://bugs.webkit.org/show_bug.cgi?id=270530 rdar://124083240 Reviewed by Stephanie Lewis and Dewei Zhu. Update build-and-collect-pgo-profiles script to use run-benchmarks' built-in HTTP server mode. This helps reduce our dependency on Twisted. * Tools/Scripts/build-and-collect-pgo-profiles: Canonical link: https://commits.webkit.org/275714@main
webkit-commit-queue
force-pushed
the
eng/build-and-collect-pgo-profiles-script-should-be-updated-to-use-run-benchmarks-built-in-HTTP-server-by-default
branch
from
8ce7bde to
e176fe2
Compare
Collaborator
|
Committed 275714@main (e176fe2): https://commits.webkit.org/275714@main Reviewed commits have been landed. Closing PR #25493 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e176fe2
8ce7bde
🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios