[GTK] Receive dropped files using the File Transfer portal#25575
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 11, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 00b3d58) Details
|
GeorgesStavracas
commented
Mar 7, 2024
Comment on lines
86
to
87
Contributor
Author
There was a problem hiding this comment.
I really dislike this. Suggestions welcomed.
I tried adding SelectionData::addGFiles but for apparently there must be a corresponding file:// URI for every reported file.
Comment on lines
216
to
231
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this kind of modification / sanitization is allowed
Contributor
There was a problem hiding this comment.
I'm not sure I understand what you are doing here.
Contributor
Author
There was a problem hiding this comment.
This block of code basically filters out file://s from the URI list.
The URI list comes as a continuous string separated by \n. So I break the URI string by newline; filter out file:// URIs; and rebuild the (continuous) list in m_uriListBuilder.
After both mimetypes and the GdkFileList are processed, I merge the GFiles as file:// URIs into the URI list.
Comment on lines
216
to
231
Contributor
There was a problem hiding this comment.
I'm not sure I understand what you are doing here.
GeorgesStavracas
force-pushed
the
eng/GTK-Drag-and-drop-does-not-work-under-flatpak
branch
from
00b3d58 to
d51e8fd
Compare
Collaborator
|
EWS run on previous version of this PR (hash d51e8fd) Details
|
GeorgesStavracas
force-pushed
the
eng/GTK-Drag-and-drop-does-not-work-under-flatpak
branch
from
d51e8fd to
ff4a631
Compare
Collaborator
|
EWS run on previous version of this PR (hash ff4a631) Details |
🧪 mac-AS-debug-wk2
GeorgesStavracas
added
the
request-merge-queue
carlosgcampos
approved these changes
Mar 11, 2024
carlosgcampos
added
the
unsafe-merge-queue
GeorgesStavracas
removed
the
unsafe-merge-queue
GeorgesStavracas
force-pushed
the
eng/GTK-Drag-and-drop-does-not-work-under-flatpak
branch
from
ff4a631 to
e7049ee
Compare
GeorgesStavracas
removed
the
request-merge-queue
Collaborator
|
EWS run on current version of this PR (hash e7049ee) Details
|
TingPing
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=212079 Reviewed by Carlos Garcia Campos. GTK4 has content serializers and deserializers that are able to read from, and write to, the File Transfer portal. They're used when using the high level content formats API, i.e. using GTypes. In particular, GTK4 is able to convert from "application/vnd.portal.filetransfer" (and the legacy "application/vnd.portal.files") from and into GdkFileLists. The DropTargetGtk4 code did not advertise the GdkFileList GType as a potential data offering, so GTK4 was never able to let the File Transfer portal conversion happen. Add the GdkFileList GType to the content formats. This creates a small conflict: many apps, e.g. Nautilus, advertise files both as "application/vnd.portal.filetransfer", and as "text/uri-list". The file URIs under "text/uri-list" are meaningless to sandboxed apps, as they might be in innaccessible locations. Which is why I've made the executive decision to ignore "file://" URIs when the File Transfer portal is used. Other types of URIs are preserved. (Other browsers take a more radical approach of ignoring all URIs on the presence of the File Transfer portal vendor.) * Source/WebKit/UIProcess/API/gtk/DropTarget.h: * Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp: (WebKit::DropTarget::DropTarget): (WebKit::DropTarget::accept): (WebKit::DropReadAsyncData::DropReadAsyncData): (WebKit::DropTarget::loadData): (WebKit::DropTarget::didLoadData): Canonical link: https://commits.webkit.org/275908@main
webkit-commit-queue
force-pushed
the
eng/GTK-Drag-and-drop-does-not-work-under-flatpak
branch
from
e7049ee to
ff20e45
Compare
Collaborator
|
Committed 275908@main (ff20e45): https://commits.webkit.org/275908@main Reviewed commits have been landed. Closing PR #25575 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
GeorgesStavracas
deleted the
eng/GTK-Drag-and-drop-does-not-work-under-flatpak
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ff20e45
e7049ee
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-skia🧪 api-ios🧪 mac-wk2🛠 gtk🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim