Rename RenderStyle effectiveUserModify() to usedUserModify() & effectiveUserSelect() to usedUserSelect()#25626
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 8, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash f83bd5f) Details |
pxlcoder
approved these changes
Mar 8, 2024
…iveUserSelect() to usedUserSelect() https://bugs.webkit.org/show_bug.cgi?id=270695 Reviewed by Aditya Keerthi. This aligns it with terminology used in CSS standards. * Source/WebCore/dom/Node.cpp: (WebCore::computeEditabilityFromComputedStyle): (WebCore::Node::canStartSelection const): * Source/WebCore/dom/Position.cpp: (WebCore::Position::nodeIsUserSelectNone): (WebCore::Position::nodeIsUserSelectAll): * Source/WebCore/editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): * Source/WebCore/editing/TextIterator.cpp: (WebCore::isRendererVisible): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::selectCursor): * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::rangeForPoint): * Source/WebCore/page/TextIndicator.cpp: (WebCore::TextIndicator::createWithRange): * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegion::unite): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange): (WebCore::RenderElement::selectionColor const): (WebCore::RenderElement::selectionBackgroundColor const): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::collectSelectionGeometriesInternal): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::usedUserSelect const): (WebCore::RenderStyle::effectiveUserSelect const): Deleted. * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::usedUserModify const): (WebCore::RenderStyle::effectiveUserModify const): Deleted. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::isSelectableTextNode const): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::selectionPositionInformation): Canonical link: https://commits.webkit.org/275844@main
f83bd5f to
2169972
Compare
Collaborator
|
Committed 275844@main (2169972): https://commits.webkit.org/275844@main Reviewed commits have been landed. Closing PR #25626 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2169972
f83bd5f