Skip to content

Remove Quirk when booking.com sends simple JPEG instead of JPEG2000 to WebKit on iOS #25760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

Remove Quirk when booking.com sends simple JPEG instead of JPEG2000 to WebKit on iOS #25760

merged 1 commit into from
Mar 13, 2024

Conversation

@karlcow
Copy link
Member

@karlcow karlcow commented Mar 12, 2024 •
edited by webkit-early-warning-system
Loading

9374282

Remove Quirk when booking.com sends simple JPEG instead of JPEG2000 to WebKit on iOS
https://bugs.webkit.org/show_bug.cgi?id=269876
rdar://123409087

Reviewed by Chris Dumez.

Booking.com doesn't JPEG2 anymore to Safari since March 8, 2024.
The Quirk can be removed.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateRequestAndAddExtraFields):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::prepareFetch):
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::acceptHeaderValueFromType):
(WebCore::CachedResourceRequest::setAcceptHeaderIfNone):
* Source/WebCore/loader/cache/CachedResourceRequest.h:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldSendLongerAcceptHeaderQuirk): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/276027@main

542641c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
💥 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@karlcow karlcow requested a review from cdumez as a code owner March 12, 2024 05:22
@karlcow karlcow self-assigned this Mar 12, 2024
@karlcow karlcow added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 12, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 12, 2024 •
edited
Loading

EWS run on current version of this PR (hash 542641c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
💥 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@karlcow karlcow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 12, 2024
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Mar 13, 2024

Failed api-ios checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #25760 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 13, 2024
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Mar 13, 2024

Safe-Merge-Queue: Build #14784.

@karlcow karlcow added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 13, 2024
@karlcow
Copy link
Member Author

karlcow commented Mar 13, 2024

The failures on api-ios are unrelated.

@cdumez cdumez added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Mar 13, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the 269876-remove-quirk-booking branch from 542641c to d3f2622 Compare March 13, 2024 15:38
@karlcow @cdumez
Remove Quirk when booking.com sends simple JPEG instead of JPEG2000 t…
9374282 
…o WebKit on iOS

https://bugs.webkit.org/show_bug.cgi?id=269876
rdar://123409087

Reviewed by Chris Dumez.

Booking.com doesn't JPEG2 anymore to Safari since March 8, 2024.
The Quirk can be removed.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateRequestAndAddExtraFields):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::prepareFetch):
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::acceptHeaderValueFromType):
(WebCore::CachedResourceRequest::setAcceptHeaderIfNone):
* Source/WebCore/loader/cache/CachedResourceRequest.h:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldSendLongerAcceptHeaderQuirk): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/276027@main
@webkit-commit-queue webkit-commit-queue force-pushed the 269876-remove-quirk-booking branch from d3f2622 to 9374282 Compare March 13, 2024 15:41
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Mar 13, 2024

Committed 276027@main (9374282): https://commits.webkit.org/276027@main

Reviewed commits have been landed. Closing PR #25760 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9374282 into WebKit:main Mar 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@karlcow karlcow

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karlcow @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @cdumez