REGRESSION (iOS 17.4, macOS 14.4, 270890@main): Animating element with display: none still remain visible#25814
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 13, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 39cf6ec) Details |
anttijk
added
the
Layout and Rendering
anttijk
force-pushed
the
animation-mutation-none
branch
from
39cf6ec to
5914ae1
Compare
Collaborator
|
EWS run on current version of this PR (hash 5914ae1) Details |
darinadler
approved these changes
Mar 13, 2024
graouts
approved these changes
Mar 13, 2024
…h display: none still remain visible https://bugs.webkit.org/show_bug.cgi?id=270697 rdar://124289418 Reviewed by Antoine Quint and Darin Adler. The page sets the root of the overlay containing tree to display:none and immediately (before style recall) reinserts it into another position in the document, causing render tree teardown. When we recompute the style (applying display:none) we don't consider it a style change since there was no existing style due to the earlier teardown. In this case we fail to clear lastStyleChangeEventStyle which has been set by an animation on the element. Another animation triggered style recalc comes along, takes the optimized AnimationOnly code path and picks up the lastStyleChangeEventStyle (which doesn't have display:none) bringing the element back alive. * LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none-expected.html: Added. * LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none.html: Added. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): Fix by clearing lastStyleChangeEventStyle also when we have a style change to display:none without existing renderer. Canonical link: https://commits.webkit.org/276035@main
webkit-commit-queue
force-pushed
the
animation-mutation-none
branch
from
5914ae1 to
d83537a
Compare
Collaborator
|
Committed 276035@main (d83537a): https://commits.webkit.org/276035@main Reviewed commits have been landed. Closing PR #25814 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d83537a
5914ae1
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2