Skip to content

Move more ivars from WKWebViewConfiguration to API::PageConfiguration#25928

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
achristensen07:eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
Mar 15, 2024
Merged

Move more ivars from WKWebViewConfiguration to API::PageConfiguration#25928
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
achristensen07:eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration

Conversation

@achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Mar 15, 2024

5512680

Move more ivars from WKWebViewConfiguration to API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=271034
rdar://124659985

Reviewed by Sihui Liu.

This is in preparation for moving PageConfiguration initialization to platform-independent
WebPageProxy::createNewPage.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::legacyEncryptedMediaAPIEnabled const):
(API::PageConfiguration::setLegacyEncryptedMediaAPIEnabled):
(API::PageConfiguration::allowMediaContentTypesRequiringHardwareSupportAsFallback const):
(API::PageConfiguration::setAllowMediaContentTypesRequiringHardwareSupportAsFallback):
(API::PageConfiguration::colorFilterEnabled const):
(API::PageConfiguration::setColorFilterEnabled):
(API::PageConfiguration::incompleteImageBorderEnabled const):
(API::PageConfiguration::setIncompleteImageBorderEnabled):
(API::PageConfiguration::shouldDeferAsynchronousScriptsUntilAfterDocumentLoad const):
(API::PageConfiguration::setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad):
(API::PageConfiguration::undoManagerAPIEnabled const):
(API::PageConfiguration::setUndoManagerAPIEnabled):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _colorFilterEnabled]):
(-[WKWebViewConfiguration _setColorFilterEnabled:]):
(-[WKWebViewConfiguration _incompleteImageBorderEnabled]):
(-[WKWebViewConfiguration _setIncompleteImageBorderEnabled:]):
(-[WKWebViewConfiguration _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad]):
(-[WKWebViewConfiguration _setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad:]):
(-[WKWebViewConfiguration _drawsBackground]):
(-[WKWebViewConfiguration _setDrawsBackground:]):
(-[WKWebViewConfiguration _setLegacyEncryptedMediaAPIEnabled:]):
(-[WKWebViewConfiguration _legacyEncryptedMediaAPIEnabled]):
(-[WKWebViewConfiguration _setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
(-[WKWebViewConfiguration _allowMediaContentTypesRequiringHardwareSupportAsFallback]):
(-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]):
(-[WKWebViewConfiguration _undoManagerAPIEnabled]):

Canonical link: https://commits.webkit.org/276178@main

929111c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 requested a review from cdumez as a code owner March 15, 2024 04:57
@achristensen07 achristensen07 self-assigned this Mar 15, 2024
@achristensen07 achristensen07 added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Mar 15, 2024
Copy link
Contributor

@szewai szewai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=271034
rdar://124659985

Reviewed by Sihui Liu.

This is in preparation for moving PageConfiguration initialization to platform-independent
WebPageProxy::createNewPage.

* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::legacyEncryptedMediaAPIEnabled const):
(API::PageConfiguration::setLegacyEncryptedMediaAPIEnabled):
(API::PageConfiguration::allowMediaContentTypesRequiringHardwareSupportAsFallback const):
(API::PageConfiguration::setAllowMediaContentTypesRequiringHardwareSupportAsFallback):
(API::PageConfiguration::colorFilterEnabled const):
(API::PageConfiguration::setColorFilterEnabled):
(API::PageConfiguration::incompleteImageBorderEnabled const):
(API::PageConfiguration::setIncompleteImageBorderEnabled):
(API::PageConfiguration::shouldDeferAsynchronousScriptsUntilAfterDocumentLoad const):
(API::PageConfiguration::setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad):
(API::PageConfiguration::undoManagerAPIEnabled const):
(API::PageConfiguration::setUndoManagerAPIEnabled):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _colorFilterEnabled]):
(-[WKWebViewConfiguration _setColorFilterEnabled:]):
(-[WKWebViewConfiguration _incompleteImageBorderEnabled]):
(-[WKWebViewConfiguration _setIncompleteImageBorderEnabled:]):
(-[WKWebViewConfiguration _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad]):
(-[WKWebViewConfiguration _setShouldDeferAsynchronousScriptsUntilAfterDocumentLoad:]):
(-[WKWebViewConfiguration _drawsBackground]):
(-[WKWebViewConfiguration _setDrawsBackground:]):
(-[WKWebViewConfiguration _setLegacyEncryptedMediaAPIEnabled:]):
(-[WKWebViewConfiguration _legacyEncryptedMediaAPIEnabled]):
(-[WKWebViewConfiguration _setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
(-[WKWebViewConfiguration _allowMediaContentTypesRequiringHardwareSupportAsFallback]):
(-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]):
(-[WKWebViewConfiguration _undoManagerAPIEnabled]):

Canonical link: https://commits.webkit.org/276178@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration branch from 929111c to 5512680 Compare March 15, 2024 18:47
@webkit-commit-queue
Copy link
Collaborator

Committed 276178@main (5512680): https://commits.webkit.org/276178@main

Reviewed commits have been landed. Closing PR #25928 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5512680 into WebKit:main Mar 15, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit API For issues and bugs in the Web Kit public embedding APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants