Simplify Navigation::scriptExecutionContext()

[TingPing]

30c07bf

Simplify Navigation::scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=271161

Reviewed by Chris Dumez.

As Navigation is a LocalDOMWindowProperty it always has
access to its own ScriptExecutionContext.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::navigation):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::Navigation):
(WebCore::Navigation::initializeEntries):
(WebCore::Navigation::scriptExecutionContext const):
(WebCore::Navigation::serializeState):
(WebCore::Navigation::navigate):
(WebCore::Navigation::updateCurrentEntry):
(WebCore::Navigation::updateForNavigation):
* Source/WebCore/page/Navigation.h:
* Source/WebCore/page/Navigation.idl:

Canonical link: https://commits.webkit.org/276478@main

6b35672

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash e5b88b3)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

[rwlbuis]

LGTM.

[darinadler]

@cdumez, I would like to understand if the script execution context can ever be a different document from the same website.

[cdumez]

@cdumez, I would like to understand if the script execution context can ever be a different document from the same website.

When dealing with a Page (not workers), a ScriptExecutionContext is a Document. There is one per frame on the page. ScriptExecutionContexts are generally not aware of each other unless they have the same security origin (otherwise the frames wouldn't be able to script each other).

The patch here does have some behavior change I believe because of the changes to the IDL. The IDL used to do CallWith=CurrentScriptExecutionContext for navigate(). IIRC, this means we were passing the caller's scriptExecutionContext to navigate(), which may be distinct from the Navigation object's ScriptExecutionContext.

e.g. otherWindow.navigate() where Frame A is calling navigate on another same origin iframe's Window. I didn't look into details to see which ScriptExecutionContext navigate() is supposed to use per the specification. However, we need to be mindful that there is a behavior change here and that it may or may not be in the right direction.

[TingPing]

The patch here does have some behavior change I believe because of the changes to the IDL.

FWIW the IDL attribute there before was just a webkit change.

There are some cross-document parts of the spec but I’m not sure we need their context. It’s something I’m aware of going forward as I understand it more now.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1f39161)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	🛠 ios	🛠 mac	🛠 wpe	💥 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 wpe-skia
	❌ 🧪 api-ios	🧪 mac-wk2	🛠 gtk
	🛠 tv	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	🛠 tv-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🛠 watch
	🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 6b35672)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 276478@main (30c07bf): https://commits.webkit.org/276478@main

Reviewed commits have been landed. Closing PR #26054 and removing active labels.