UnifiedPDF: Find-in-page highlights very unstable during zoom#26069
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 19, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash 83994b9) Details
|
smfr
approved these changes
Mar 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=271177 Reviewed by Simon Fraser. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::setScaleFactor): Adopt our `scrollToPoint` helper, which also makes this a programmatic scroll, which is important to make its application synchronous in the Web Content process, so that we can correctly repaint the overlay synchronously. * Source/WebKit/WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindUIAfterPageScroll): Disable async scrolling for UnifiedPDFPlugin while the find overlay is installed. Canonical link: https://commits.webkit.org/276316@main
webkit-commit-queue
force-pushed
the
eng/UnifiedPDF-Find-in-page-highlights-very-unstable-during-zoom
branch
from
83994b9 to
c52386b
Compare
Collaborator
|
Committed 276316@main (c52386b): https://commits.webkit.org/276316@main Reviewed commits have been landed. Closing PR #26069 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c52386b
83994b9
🛠 wincairo🧪 wpe-wk2🧪 api-wpe🧪 ios-wk2-wpt🧪 gtk-wk2🛠 tv-sim🧪 api-gtk🛠 watch