Skip to content

Remove Quirk shouldDisablePopoverAttributeQuirk for apple-console.lrn.com #26103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Mar 21, 2024
Merged

Remove Quirk shouldDisablePopoverAttributeQuirk for apple-console.lrn.com #26103

webkit-commit-queue merged 1 commit into from
Mar 21, 2024

Conversation

@karlcow
Copy link
Member

@karlcow karlcow commented Mar 19, 2024 •
edited by webkit-early-warning-system
Loading

45bc0fd

Remove Quirk shouldDisablePopoverAttributeQuirk for apple-console.lrn.com
https://bugs.webkit.org/show_bug.cgi?id=271216
rdar://124989024

Reviewed by Tim Nguyen and Anne van Kesteren.

The bug was fixed in the initial library which was used by the apple site.
On May 2023, the site owners confirmed that they had fixed the issue on
their side and adjusted the library. The Quirk can be removed.
The Quirk was added by
https://bugs.webkit.org/show_bug.cgi?id=255373
rdar://106779034

* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::attributeChanged):
* Source/WebCore/html/HTMLElement.idl:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::popoverTargetElement const):
* Source/WebCore/html/PopoverInvokerElement.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisablePopoverAttributeQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Canonical link: https://commits.webkit.org/276498@main

8d5e556

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@karlcow karlcow requested review from cdumez and rniwa as code owners March 19, 2024 05:37
@karlcow karlcow self-assigned this Mar 19, 2024
@karlcow karlcow added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 19, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 9914a75)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl loading-orange 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 loading-orange 🧪 gtk-wk2
✅ 🛠 tv-sim loading-orange 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@karlcow karlcow requested a review from nt1m March 19, 2024 05:38
@karlcow karlcow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 19, 2024
@annevk annevk removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 19, 2024
annevk
annevk reviewed Mar 19, 2024
View reviewed changes
@karlcow karlcow force-pushed the 271216-remove-shouldDisablePopoverAttributeQuirk branch from 9914a75 to 8d5e556 Compare March 21, 2024 04:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 21, 2024 •
edited
Loading

EWS run on current version of this PR (hash 8d5e556)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 21, 2024
@karlcow karlcow added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 21, 2024
@karlcow
Copy link
Member Author

karlcow commented Mar 21, 2024

The failure in mac-wk1 is unrelated.

@karlcow
Remove Quirk shouldDisablePopoverAttributeQuirk for apple-console.lrn…
45bc0fd 
….com

https://bugs.webkit.org/show_bug.cgi?id=271216
rdar://124989024

Reviewed by Tim Nguyen and Anne van Kesteren.

The bug was fixed in the initial library which was used by the apple site.
On May 2023, the site owners confirmed that they had fixed the issue on
their side and adjusted the library. The Quirk can be removed.
The Quirk was added by
https://bugs.webkit.org/show_bug.cgi?id=255373
rdar://106779034

* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::attributeChanged):
* Source/WebCore/html/HTMLElement.idl:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::popoverTargetElement const):
* Source/WebCore/html/PopoverInvokerElement.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisablePopoverAttributeQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Canonical link: https://commits.webkit.org/276498@main
@webkit-commit-queue webkit-commit-queue force-pushed the 271216-remove-shouldDisablePopoverAttributeQuirk branch from 8d5e556 to 45bc0fd Compare March 21, 2024 22:46
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Mar 21, 2024

Committed 276498@main (45bc0fd): https://commits.webkit.org/276498@main

Reviewed commits have been landed. Closing PR #26103 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 45bc0fd into WebKit:main Mar 21, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 21, 2024
@karlcow karlcow deleted the 271216-remove-shouldDisablePopoverAttributeQuirk branch March 22, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

@nt1m nt1m nt1m approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@karlcow karlcow

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@karlcow @webkit-early-warning-system @webkit-commit-queue @annevk @nt1m @webkit-ews-buildbot