[iOS] AVVideoCaptureSource is not handling the case of another application changing the device videoZoomFactor#26406
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 27, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 70873ce) Details |
eric-carlson
approved these changes
Mar 25, 2024
70873ce to
4c57ed8
Compare
Collaborator
|
EWS run on current version of this PR (hash 4c57ed8) Details |
…ation changing the device videoZoomFactor https://bugs.webkit.org/show_bug.cgi?id=271643 rdar://125351159 Reviewed by Eric Carlson. When another application is changing the device zoom, it got access to the device so AVVideoCaptureSource is not running. When AVVideoCaptureSource restarts, we just have to reapply the device zoom. Remove AVVideoCaptureSource::m_appliedZoom since the device videoZoomFactor can change when other iOS apps get access to the camera. We thus always compare the zoom to be applied with the device zoom. * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h: * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::setSessionSizeFrameRateAndZoom): Canonical link: https://commits.webkit.org/276731@main
4c57ed8 to
ca83b80
Compare
Collaborator
|
Committed 276731@main (ca83b80): https://commits.webkit.org/276731@main Reviewed commits have been landed. Closing PR #26406 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ca83b80
4c57ed8