[GTK] Port SelectionData to new IPC serialization format by csaavedra · Pull Request #26564 · WebKit/WebKit

csaavedra · 2024-03-28T17:28:24Z

`41e8f10`

[GTK] Port SelectionData to new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=271836

Reviewed by Carlos Garcia Campos.

Remove the ArgumentCoders for SelectionData, adapt the
class a bit to make it work well with the generated serializers,
and add a new ArgumentCodersGtk.serialization.in for the
GTK-specific serializers.

* Source/WebCore/platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::typesSafeForBindings):
(WebCore::Pasteboard::readOrigin):
(WebCore::Pasteboard::readStringInCustomData):
* Source/WebCore/platform/gtk/SelectionData.cpp:
(WebCore::SelectionData::SelectionData):
* Source/WebCore/platform/gtk/SelectionData.h:
(WebCore::SelectionData::setImage):
(WebCore::SelectionData::image const):
(WebCore::SelectionData::customData const):
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::encodeImage): Deleted.
(IPC::decodeImage): Deleted.
(IPC::ArgumentCoder<SelectionData>::encode): Deleted.
(IPC::ArgumentCoder<SelectionData>::decode): Deleted.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.h:
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: Added.
* Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp:
(WebKit::DragSource::DragSource):
* Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp:
(WebKit::Clipboard::write):

Canonical link: https://commits.webkit.org/276991@main

c590209

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 gtk-wk2
	~~🛠 tv-sim~~		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-28T17:33:09Z

EWS run on previous version of this PR (hash 9842b76)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	~~🛠 tv-sim~~		❌ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-03-28T17:50:08Z

EWS run on previous version of this PR (hash e08f4c4)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-04-02T15:39:08Z

EWS run on previous version of this PR (hash 43aeb2a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-04-03T07:06:25Z

EWS run on previous version of this PR (hash b7ab23c)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~		✅ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

Source/WebCore/platform/gtk/SelectionData.h

Source/WebCore/platform/gtk/PasteboardGtk.cpp

webkit-early-warning-system · 2024-04-03T08:41:33Z

EWS run on previous version of this PR (hash 475930a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv-sim~~		✅ 🧪 api-gtk
	~~🛠 watch~~
	✅ 🛠 watch-sim

carlosgcampos · 2024-04-03T08:52:04Z

Source/WebCore/platform/gtk/SelectionData.h

Suggested change

void setImage(RefPtr<Image>&& newImage) { m_image = newImage; }

void setImage(RefPtr<Image>&& newImage) { m_image = WTFMove(newImage); }

carlosgcampos · 2024-04-03T08:52:33Z

Source/WebCore/platform/gtk/SelectionData.cpp

Suggested change

SelectionData::SelectionData(const String& text, const String& markup, const URL& url, const String& uriList, RefPtr<WebCore::Image> image, RefPtr<WebCore::SharedBuffer>&& buffer, bool canSmartReplace)

SelectionData::SelectionData(const String& text, const String& markup, const URL& url, const String& uriList, RefPtr<WebCore::Image>&& image, RefPtr<WebCore::SharedBuffer>&& buffer, bool canSmartReplace)

carlosgcampos · 2024-04-03T08:53:10Z

Source/WebCore/platform/gtk/SelectionData.cpp

Suggested change

setImage(image.get());

setImage(WTFMove(image));

webkit-early-warning-system · 2024-04-03T09:08:46Z

EWS run on current version of this PR (hash c590209)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 gtk-wk2
	~~🛠 tv-sim~~		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	~~🛠 watch~~
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=271836 Reviewed by Carlos Garcia Campos. Remove the ArgumentCoders for SelectionData, adapt the class a bit to make it work well with the generated serializers, and add a new ArgumentCodersGtk.serialization.in for the GTK-specific serializers. * Source/WebCore/platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::typesSafeForBindings): (WebCore::Pasteboard::readOrigin): (WebCore::Pasteboard::readStringInCustomData): * Source/WebCore/platform/gtk/SelectionData.cpp: (WebCore::SelectionData::SelectionData): * Source/WebCore/platform/gtk/SelectionData.h: (WebCore::SelectionData::setImage): (WebCore::SelectionData::image const): (WebCore::SelectionData::customData const): * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: (IPC::encodeImage): Deleted. (IPC::decodeImage): Deleted. (IPC::ArgumentCoder<SelectionData>::encode): Deleted. (IPC::ArgumentCoder<SelectionData>::decode): Deleted. * Source/WebKit/Shared/gtk/ArgumentCodersGtk.h: * Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: Added. * Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp: (WebKit::DragSource::DragSource): * Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp: (WebKit::Clipboard::write): Canonical link: https://commits.webkit.org/276991@main

webkit-commit-queue · 2024-04-03T11:03:31Z

Committed 276991@main (41e8f10): https://commits.webkit.org/276991@main

Reviewed commits have been landed. Closing PR #26564 and removing active labels.

csaavedra self-assigned this Mar 28, 2024

csaavedra added the WebKitGTK Bugs related to the Gtk API layer. label Mar 28, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 28, 2024

csaavedra removed the merging-blocked Applied to prevent a change from being merged label Mar 28, 2024

csaavedra force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from 9842b76 to e08f4c4 Compare March 28, 2024 17:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 28, 2024

csaavedra removed the merging-blocked Applied to prevent a change from being merged label Apr 2, 2024

csaavedra force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from e08f4c4 to 43aeb2a Compare April 2, 2024 15:39

csaavedra marked this pull request as ready for review April 2, 2024 20:13

csaavedra requested a review from a team as a code owner April 2, 2024 20:13

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 2, 2024

csaavedra removed the merging-blocked Applied to prevent a change from being merged label Apr 3, 2024

csaavedra force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from 43aeb2a to b7ab23c Compare April 3, 2024 07:06

carlosgcampos reviewed Apr 3, 2024

View reviewed changes

Source/WebCore/platform/gtk/SelectionData.h Outdated Show resolved Hide resolved

Source/WebCore/platform/gtk/SelectionData.h Outdated Show resolved Hide resolved

Source/WebCore/platform/gtk/PasteboardGtk.cpp Outdated Show resolved Hide resolved

csaavedra force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from b7ab23c to 475930a Compare April 3, 2024 08:41

csaavedra requested a review from carlosgcampos April 3, 2024 08:41

carlosgcampos approved these changes Apr 3, 2024

View reviewed changes

csaavedra force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from 475930a to c590209 Compare April 3, 2024 09:08

csaavedra added the merge-queue Applied to send a pull request to merge-queue label Apr 3, 2024

webkit-commit-queue force-pushed the eng/GTK-Port-SelectionData-to-new-IPC-serialization-format branch from c590209 to 41e8f10 Compare April 3, 2024 11:03

webkit-commit-queue merged commit 41e8f10 into WebKit:main Apr 3, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GTK] Port SelectionData to new IPC serialization format#26564

[GTK] Port SelectionData to new IPC serialization format#26564
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
csaavedra:eng/GTK-Port-SelectionData-to-new-IPC-serialization-format

csaavedra commented Mar 28, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Mar 28, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 28, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 2, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading

Uh oh!

carlosgcampos Apr 3, 2024

Uh oh!

carlosgcampos Apr 3, 2024

Uh oh!

carlosgcampos Apr 3, 2024

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading

Uh oh!

webkit-commit-queue commented Apr 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

	void setImage(RefPtr<Image>&& newImage) { m_image = newImage; }
	void setImage(RefPtr<Image>&& newImage) { m_image = WTFMove(newImage); }

	SelectionData::SelectionData(const String& text, const String& markup, const URL& url, const String& uriList, RefPtr<WebCore::Image> image, RefPtr<WebCore::SharedBuffer>&& buffer, bool canSmartReplace)
	SelectionData::SelectionData(const String& text, const String& markup, const URL& url, const String& uriList, RefPtr<WebCore::Image>&& image, RefPtr<WebCore::SharedBuffer>&& buffer, bool canSmartReplace)

Conversation

csaavedra commented Mar 28, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

41e8f10

Uh oh!

webkit-early-warning-system commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlosgcampos Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

carlosgcampos Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

carlosgcampos Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Apr 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

csaavedra commented Mar 28, 2024 •

edited by webkit-early-warning-system

Loading

`41e8f10`

webkit-early-warning-system commented Mar 28, 2024 •

edited

Loading

webkit-early-warning-system commented Mar 28, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 2, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading

webkit-early-warning-system commented Apr 3, 2024 •

edited

Loading