xhr/json.any.html WPT test is failing in WebKit #2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
WebCore Misc.
webkit-early-warning-system
added
the
merging-blocked
cdumez
force-pushed
the
243109_xhr_json_utf8
branch
from
cf011f7 to
6bea177
Compare
cdumez
requested review from
achristensen07,
darinadler,
geoffreygaren and
youennf
darinadler
approved these changes
Jul 26, 2022
Member
There was a problem hiding this comment.
I think we should remove the argument here. Only use this when it’s true.
cdumez
force-pushed
the
243109_xhr_json_utf8
branch
from
6bea177 to
8080601
Compare
webkit-early-warning-system
force-pushed
the
243109_xhr_json_utf8
branch
from
8080601 to
deb6046
Compare
https://bugs.webkit.org/show_bug.cgi?id=243109 Reviewed by Darin Adler. Force UTF-8 decoding for XHR response when responseType is json. This aligns our behavior with Blink and Gecko. * LayoutTests/imported/w3c/web-platform-tests/xhr/json.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/xhr/json.any.worker-expected.txt: * Source/WebCore/loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding): (WebCore::TextResourceDecoder::checkForBOM): * Source/WebCore/loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::setAlwaysUseUTF8): * Source/WebCore/xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createDecoder const): Canonical link: https://commits.webkit.org/252838@main
webkit-early-warning-system
force-pushed
the
243109_xhr_json_utf8
branch
from
deb6046 to
c74e2dd
Compare
Collaborator
|
Committed 252838@main (c74e2dd): https://commits.webkit.org/252838@main Reviewed commits have been landed. Closing PR #2667 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c74e2dd