[visionOS] After exiting docked fullscreen, element fullscreen window contains only a view snapshot#26809
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 3, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash fe6dd81) Details
|
jernoble
approved these changes
Apr 3, 2024
aestes
added
unsafe-merge-queue
webkit-commit-queue
force-pushed
the
eng/visionOS-After-exiting-docked-fullscreen-element-fullscreen-window-contains-only-a-view-snapshot
branch
from
fe6dd81 to
dd3243b
Compare
… contains only a view snapshot https://bugs.webkit.org/show_bug.cgi?id=272114 rdar://125734832 Reviewed by Jer Noble. Element fullscreen expects to exit when switching to LinearMediaPlayer fullscreen, but we lack the API from LinearMediaKit to do this properly. As a result, when exiting LinearMediaKit fullscreen the element fullscreen window remains visible with a view snapshot displayed in place of the web view. Work around this issue by exiting element fullscreen when we receive a video receiver endpoint. * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm: (WebKit::PlaybackSessionManagerProxy::setVideoReceiverEndpoint): Canonical link: https://commits.webkit.org/277031@main
webkit-commit-queue
force-pushed
the
eng/visionOS-After-exiting-docked-fullscreen-element-fullscreen-window-contains-only-a-view-snapshot
branch
from
dd3243b to
c73791d
Compare
Collaborator
|
Committed 277031@main (c73791d): https://commits.webkit.org/277031@main Reviewed commits have been landed. Closing PR #26809 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
aestes
deleted the
eng/visionOS-After-exiting-docked-fullscreen-element-fullscreen-window-contains-only-a-view-snapshot
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c73791d
fe6dd81
🛠 ios-sim🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 api-gtk🛠 watch🛠 watch-sim