[Remote Inspection] Targeting heuristic may surface redundant elements in shadow roots

[whsieh]

dc0433c

[Remote Inspection] Targeting heuristic may surface redundant elements in shadow roots
https://bugs.webkit.org/show_bug.cgi?id=272283
rdar://121251828

Reviewed by Megan Gardner and Richard Robinson.

Currently, in the case where a targeted element is (or contains a) shadow root that encapsulates
other candidates, we end up surfacing both the outer container element as well as the inner element
in the shadow root as targeted elements to the WebKit client.

Under normal circumstances, adding the outer element as a target should exclude the inner element
from being a candidate. However, it fails in this case because the logic to enforce this invariant:

```
candidates.removeAllMatching([&](auto& candidate) {
    if (target.ptr() != candidate.ptr() && !target->contains(candidate))
        return false;
```

...uses `Node::contains(…)`, which does not account for shadow roots into account. Fix this by
simply replacing this call with `containsIncludingShadowDOM`.

Test: ElementTargeting.ContentInsideShadowRoot

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::selectorsForTarget):

There's also no point in surfacing a CSS selector to match content in shadow roots to the client. In
a subsequent patch, we should provide an alternate means to resolve content inside of shadow roots
that doesn't rely on (or relies on more than just) CSS selectors.

(WebCore::ElementTargetingController::findTargets):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting, ContentInsideShadowRoot)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-4.html: Added.

Add a new API test to cover this scenario.

Canonical link: https://commits.webkit.org/277171@main

4c54674

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 4c54674)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[whsieh]

Thanks for the reviews!

[webkit-commit-queue]

Committed 277171@main (dc0433c): https://commits.webkit.org/277171@main

Reviewed commits have been landed. Closing PR #26941 and removing active labels.