REGRESSION (276433@main): Snapshots are partially dark-shaded.

[sammygill]

67629e3

REGRESSION (276433@main): Snapshots are partially dark-shaded.
https://bugs.webkit.org/show_bug.cgi?id=272410
rdar://125791769

Reviewed by Simon Fraser and Abrar Rahman Protyasha.

These dark regions are due to the fact that we are missing the white
background when painting the previews. This patch adds them back in the
async case since the preview is painted without the async renderer.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):

Canonical link: https://commits.webkit.org/277273@main

0177888

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	⏳ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 28adbab)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 wpe-skia
	⏳ 🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
	🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 tv-sim		⏳ 🧪 api-gtk
	🛠 watch
	✅ 🛠 watch-sim

[smfr]

You don't need this. context.fillRect() is not changing state.

[webkit-early-warning-system]

EWS run on current version of this PR (hash 0177888)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	⏳ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
✅ 🛠 🧪 merge	🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 277273@main (67629e3): https://commits.webkit.org/277273@main

Reviewed commits have been landed. Closing PR #27041 and removing active labels.