Skip to content

Add -fsanitize=local-bounds to UBSan builds #27112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add -fsanitize=local-bounds to UBSan builds #27112

merged 1 commit into from
Apr 11, 2024

Conversation

@ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented Apr 10, 2024 •
edited by webkit-early-warning-system
Loading

5cf22ee

Add -fsanitize=local-bounds to UBSan builds
https://bugs.webkit.org/show_bug.cgi?id=272481
<rdar://126231948>

Reviewed by Chris Dumez.

* Configurations/Sanitizers.xcconfig:
(WK_UNDEFINED_BEHAVIOR_SANITIZER_OTHER_CFLAGS_YES):
- Add local-bounds to existing -fsanitize argument.

Canonical link: https://commits.webkit.org/277345@main

e4851cd

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer requested a review from emw-apple as a code owner April 10, 2024 21:35
@ddkilzer ddkilzer self-assigned this Apr 10, 2024
@ddkilzer ddkilzer added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 10, 2024 •
edited
Loading

EWS run on current version of this PR (hash e4851cd)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 11, 2024
@ddkilzer
Add -fsanitize=local-bounds to UBSan builds
5cf22ee 
https://bugs.webkit.org/show_bug.cgi?id=272481
<rdar://126231948>

Reviewed by Chris Dumez.

* Configurations/Sanitizers.xcconfig:
(WK_UNDEFINED_BEHAVIOR_SANITIZER_OTHER_CFLAGS_YES):
- Add local-bounds to existing -fsanitize argument.

Canonical link: https://commits.webkit.org/277345@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add--fsanitizelocal-bounds-to-UBSan-builds branch from e4851cd to 5cf22ee Compare April 11, 2024 02:51
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Apr 11, 2024

Committed 277345@main (5cf22ee): https://commits.webkit.org/277345@main

Reviewed commits have been landed. Closing PR #27112 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5cf22ee into WebKit:main Apr 11, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 11, 2024
@ddkilzer ddkilzer deleted the eng/Add--fsanitizelocal-bounds-to-UBSan-builds branch April 11, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@ddkilzer ddkilzer

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddkilzer @webkit-early-warning-system @webkit-commit-queue @cdumez