Skip to content

[results.webkit.org] Fetch missing range commit on dashboard#27144

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
JonWBedard:eng/results-webkit-org-Fetch-missing-range-commit-on-dashboard
May 1, 2024
Merged

[results.webkit.org] Fetch missing range commit on dashboard#27144
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
JonWBedard:eng/results-webkit-org-Fetch-missing-range-commit-on-dashboard

Conversation

@JonWBedard
Copy link
Copy Markdown
Member

@JonWBedard JonWBedard commented Apr 11, 2024

a71b5c1

[results.webkit.org] Fetch missing range commit on dashboard
https://bugs.webkit.org/show_bug.cgi?id=272529
rdar://126275308

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
(prototype.addCommit): Fetch a commit by ref, and ensure that commit's UUID is contained
in the range for this CommitBank.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js:
(Dashboard.prototype.setTilesFromData): If we can't find before_ref in a CommitBank, specifically
request that ref.

Canonical link: https://commits.webkit.org/278202@main

5be38a1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@JonWBedard JonWBedard requested a review from briannafan as a code owner April 11, 2024 15:27
@JonWBedard JonWBedard self-assigned this Apr 11, 2024
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 11, 2024
@JonWBedard JonWBedard added the skip-ews Applied to prevent a change from being run on EWS label Apr 11, 2024
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 1, 2024
https://bugs.webkit.org/show_bug.cgi?id=272529
rdar://126275308

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:
(prototype.addCommit): Fetch a commit by ref, and ensure that commit's UUID is contained
in the range for this CommitBank.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js:
(Dashboard.prototype.setTilesFromData): If we can't find before_ref in a CommitBank, specifically
request that ref.

Canonical link: https://commits.webkit.org/278202@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/results-webkit-org-Fetch-missing-range-commit-on-dashboard branch from 5be38a1 to a71b5c1 Compare May 1, 2024 03:19
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 278202@main (a71b5c1): https://commits.webkit.org/278202@main

Reviewed commits have been landed. Closing PR #27144 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 1, 2024
@webkit-commit-queue webkit-commit-queue merged commit a71b5c1 into WebKit:main May 1, 2024
@JonWBedard JonWBedard deleted the eng/results-webkit-org-Fetch-missing-range-commit-on-dashboard branch May 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ews Applied to prevent a change from being run on EWS Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants