[results.webkit.org] Fetch missing range commit on dashboard#27144
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom May 1, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash 5be38a1) Details |
facetothefate
approved these changes
Apr 11, 2024
dewei-zhu
approved these changes
May 1, 2024
https://bugs.webkit.org/show_bug.cgi?id=272529 rdar://126275308 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js: (prototype.addCommit): Fetch a commit by ref, and ensure that commit's UUID is contained in the range for this CommitBank. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js: (Dashboard.prototype.setTilesFromData): If we can't find before_ref in a CommitBank, specifically request that ref. Canonical link: https://commits.webkit.org/278202@main
5be38a1 to
a71b5c1
Compare
Collaborator
|
Committed 278202@main (a71b5c1): https://commits.webkit.org/278202@main Reviewed commits have been landed. Closing PR #27144 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a71b5c1
5be38a1