Re-import html/semantics/popovers WPT#27641
Conversation
|
EWS run on previous version of this PR (hash ac77cca) Details |
There was a problem hiding this comment.
<script>
const popover6 = document.querySelector('#p6');
promise_test(async () => {
popover6.showPopover();
assert_equals(popover6.scrollTop,0,'popover6 should start non-scrolled');
await new test_driver.Actions()
.scroll(0, 0, 0, 50, {origin: popover6})
.send();
await waitForRender();
assert_true(popover6.matches(':popover-open'),'popover6 should stay open');
assert_equals(popover6.scrollTop,50,'popover6 should be scrolled');
popover6.hidePopover();
},'Scrolling within a popover should not close the popover');
</script>
This sub-test means the entire file is skipped on iOS which has led (assuming this test would even have caught it) to a nasty bug with popover sneaking through. Planning to as a follow up split this subtest into its own file so the main one can be unskipped on iOS.
|
Failed gtk-wk2, api-gtk, wpe-wk2 checks. Please resolve failures and re-apply Rejecting #27641 from merge queue. |
|
Safe-Merge-Queue: Build #18798. |
ac77cca to
af71030
Compare
|
EWS run on current version of this PR (hash af71030) Details |
|
Safe-Merge-Queue: Build #18873. |
https://bugs.webkit.org/show_bug.cgi?id=273136 Reviewed by Tim Nguyen. Upstream commit: web-platform-tests/wpt@43ae6cd * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-and-svg-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-appearance-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-appearance-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-context-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js: (async clickOn): * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/277947@main
af71030 to
8126214
Compare
|
Committed 277947@main (8126214): https://commits.webkit.org/277947@main Reviewed commits have been landed. Closing PR #27641 and removing active labels. |
8126214
af71030