Skip to content

Re-import html/semantics/popovers WPT#27641

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
lukewarlow:import-popover-new
Apr 24, 2024
Merged

Re-import html/semantics/popovers WPT#27641
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
lukewarlow:import-popover-new

Conversation

@lukewarlow
Copy link
Copy Markdown
Member

@lukewarlow lukewarlow commented Apr 23, 2024

8126214

Re-import html/semantics/popovers WPT
https://bugs.webkit.org/show_bug.cgi?id=273136

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@43ae6cd

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-and-svg-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-context-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js:
(async clickOn):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/277947@main

af71030

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@lukewarlow lukewarlow self-assigned this Apr 23, 2024
@lukewarlow lukewarlow added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 23, 2024
Copy link
Copy Markdown
Member Author

@lukewarlow lukewarlow Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<script>
  const popover6 = document.querySelector('#p6');
  promise_test(async () => {
    popover6.showPopover();
    assert_equals(popover6.scrollTop,0,'popover6 should start non-scrolled');
    await new test_driver.Actions()
       .scroll(0, 0, 0, 50, {origin: popover6})
       .send();
    await waitForRender();
    assert_true(popover6.matches(':popover-open'),'popover6 should stay open');
    assert_equals(popover6.scrollTop,50,'popover6 should be scrolled');
    popover6.hidePopover();
  },'Scrolling within a popover should not close the popover');
</script>

This sub-test means the entire file is skipped on iOS which has led (assuming this test would even have caught it) to a nasty bug with popover sneaking through. Planning to as a follow up split this subtest into its own file so the main one can be unskipped on iOS.

@lukewarlow lukewarlow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 23, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 23, 2024
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Failed gtk-wk2, api-gtk, wpe-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #27641 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 24, 2024
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safe-Merge-Queue: Build #18798.

@lukewarlow lukewarlow removed the merging-blocked Applied to prevent a change from being merged label Apr 24, 2024
@lukewarlow lukewarlow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 24, 2024
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 24, 2024
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safe-Merge-Queue: Build #18873.

@webkit-ews-buildbot webkit-ews-buildbot added the merge-queue Applied to send a pull request to merge-queue label Apr 24, 2024
https://bugs.webkit.org/show_bug.cgi?id=273136

Reviewed by Tim Nguyen.

Upstream commit: web-platform-tests/wpt@43ae6cd

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-and-svg-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-appearance-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-context-ref.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js:
(async clickOn):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/277947@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 277947@main (8126214): https://commits.webkit.org/277947@main

Reviewed commits have been landed. Closing PR #27641 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8126214 into WebKit:main Apr 24, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants