Skip to content

Removing tests using getTypeMapping() in trusted types.#27795

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ziransun:Bug273312
Apr 29, 2024
Merged

Removing tests using getTypeMapping() in trusted types.#27795
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ziransun:Bug273312

Conversation

@ziransun
Copy link
Contributor

@ziransun ziransun commented Apr 26, 2024

89a1916

Removing tests using getTypeMapping() in trusted types.
https://bugs.webkit.org/show_bug.cgi?id=273312

Reviewed by Tim Nguyen.

This is to be in line with the spec discussions at w3c/trusted-types#432

* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.html.

Canonical link: https://commits.webkit.org/278100@main

418c1df

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@ziransun ziransun self-assigned this Apr 26, 2024
@ziransun ziransun added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 26, 2024
@ziransun ziransun requested a review from lukewarlow April 26, 2024 10:56
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 26, 2024
@Ahmad-S792 Ahmad-S792 requested a review from nt1m April 27, 2024 02:26
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Apr 27, 2024
@Ahmad-S792 Ahmad-S792 requested a review from rniwa April 27, 2024 02:26
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 27, 2024
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you export to WPT?

@ziransun
Copy link
Contributor Author

Can you export to WPT?

Yes. Created PR at web-platform-tests/wpt#45950

@lukewarlow
Copy link
Member

LGTM given this isn't even proposed to be in the spec in future I don't think we need to move to tentative either.

@ziransun ziransun added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Apr 29, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Apr 29, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #19315.

https://bugs.webkit.org/show_bug.cgi?id=273312

Reviewed by Tim Nguyen.

This is to be in line with the spec discussions at w3c/trusted-types#432.

* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.html.

Canonical link: https://commits.webkit.org/278100@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278100@main (89a1916): https://commits.webkit.org/278100@main

Reviewed commits have been landed. Closing PR #27795 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 89a1916 into WebKit:main Apr 29, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments