Skip to content

Simplify allWorkers() in Worker.cpp#28033

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:273605_allWorkers_simplify
May 2, 2024
Merged

Simplify allWorkers() in Worker.cpp#28033
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:273605_allWorkers_simplify

Conversation

@cdumez
Copy link
Copy Markdown
Contributor

@cdumez cdumez commented May 2, 2024

189f000

Simplify allWorkers() in Worker.cpp
https://bugs.webkit.org/show_bug.cgi?id=273605

Reviewed by Per Arne Vollan and Youenn Fablet.

Simplify allWorkers() in Worker.cpp. It doesn't need to store the Worker objects,
we never use them.

* Source/WebCore/workers/Worker.cpp:
(WebCore::WTF_REQUIRES_LOCK):
(WebCore::Worker::networkStateChanged):
(WebCore::Worker::Worker):
(WebCore::Worker::~Worker):
(WebCore::Worker::forEachWorker):

Canonical link: https://commits.webkit.org/278258@main

48ac5c4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe loading 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2 loading-orange 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this May 2, 2024
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 2, 2024
@cdumez cdumez requested review from geoffreygaren and rniwa May 2, 2024 04:03
Copy link
Copy Markdown
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=273605

Reviewed by Per Arne Vollan and Youenn Fablet.

Simplify allWorkers() in Worker.cpp. It doesn't need to store the Worker objects,
we never use them.

* Source/WebCore/workers/Worker.cpp:
(WebCore::WTF_REQUIRES_LOCK):
(WebCore::Worker::networkStateChanged):
(WebCore::Worker::Worker):
(WebCore::Worker::~Worker):
(WebCore::Worker::forEachWorker):

Canonical link: https://commits.webkit.org/278258@main
@webkit-commit-queue webkit-commit-queue force-pushed the 273605_allWorkers_simplify branch from 48ac5c4 to 189f000 Compare May 2, 2024 14:41
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 278258@main (189f000): https://commits.webkit.org/278258@main

Reviewed commits have been landed. Closing PR #28033 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 189f000 into WebKit:main May 2, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants