Skip to content

Add a quirk for gmail on ApplicationCache #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 1 commit into from
Jul 29, 2022
Merged

Add a quirk for gmail on ApplicationCache #2815

webkit-early-warning-system merged 1 commit into from
Jul 29, 2022

Conversation

@szewai
Copy link
Contributor

@szewai szewai commented Jul 28, 2022 •
edited by webkit-commit-queue
Loading

ba526d2

Add a quirk for gmail on ApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=243298
rdar://97351877

Reviewed by Chris Dumez.

Enable window.applicationcache on gmail until they fix rdar://97727706.

* Source/WebCore/loader/appcache/DOMApplicationCache.idl:
* Source/WebCore/page/DOMWindow.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldEnableApplicationCacheQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/252942@main

@szewai szewai requested a review from cdumez as a code owner July 28, 2022 16:37
@szewai szewai self-assigned this Jul 28, 2022
@szewai szewai added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Jul 28, 2022
cdumez
cdumez approved these changes Jul 28, 2022
View reviewed changes
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 28, 2022
@szewai szewai removed the merging-blocked Applied to prevent a change from being merged label Jul 28, 2022
@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Jul 29, 2022
@szewai
Add a quirk for gmail on ApplicationCache
ba526d2 
https://bugs.webkit.org/show_bug.cgi?id=243298
rdar://97351877

Reviewed by Chris Dumez.

Enable window.applicationcache on gmail until they fix rdar://97727706.

* Source/WebCore/loader/appcache/DOMApplicationCache.idl:
* Source/WebCore/page/DOMWindow.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldEnableApplicationCacheQuirk const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/252942@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jul 29, 2022

Committed 252942@main (ba526d2): https://commits.webkit.org/252942@main

Reviewed commits have been landed. Closing PR #2815 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit ba526d2 into WebKit:main Jul 29, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 29, 2022
@szewai szewai deleted the eng/bug_243298 branch August 30, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@szewai szewai

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szewai @webkit-commit-queue @cdumez @webkit-early-warning-system